Prepend line directive to copied source files #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
requested changes
Mar 17, 2023
| @@ -50,6 +53,14 @@ func WithModules(t *testing.T, srcdir string, modfile io.Reader) (dir string) { | |||
| } | |||
|
|
|||
| for _, file := range files { | |||
| // Prepend line directive to .go files | |||
| if strings.HasSuffix(file.Name(), ".go") { | |||
| // Prepend line directive to .go files | ||
| if strings.HasSuffix(file.Name(), ".go") { | ||
| fn := filepath.Join(path, file.Name()) | ||
| originalFn := strings.TrimPrefix(fn, dir) |
| fn := filepath.Join(path, file.Name()) | ||
| originalFn := strings.TrimPrefix(fn, dir) | ||
| if err := prependToFile(fn, fmt.Sprintf("//line %s:1\n", originalFn)); err != nil { | ||
| t.Fatal("cannot prepend.") |
| @@ -85,6 +96,50 @@ func WithModules(t *testing.T, srcdir string, modfile io.Reader) (dir string) { | |||
| return dir | |||
| } | |||
|
|
|||
| func appendFileContent(tmp io.Writer, filename string) error { | |||
| f, err := os.OpenFile(filename, os.O_RDONLY, 0600) | |||
| if strings.HasSuffix(file.Name(), ".go") { | ||
| fn := filepath.Join(path, file.Name()) | ||
| originalFn := strings.TrimPrefix(fn, dir) | ||
| if err := prependToFile(fn, fmt.Sprintf("//line %s:1\n", originalFn)); err != nil { |
There was a problem hiding this comment.
fmt.Sprintf使うなら直接fmt.Fprintlnでファイルに出力したら良いと思いました。
| return nil | ||
| } | ||
|
|
||
| func prependToFile(filename string, content string) error { |
| } | ||
| // Write the original file content | ||
| if err := appendFileContent(tmp, filename); err != nil { | ||
| tmp.Close() |
| // Write the original file content | ||
| if err := appendFileContent(tmp, filename); err != nil { | ||
| tmp.Close() | ||
| os.Remove(tmpFilePath) |
k1LoW
added a commit
to k1LoW/testutil
that referenced
this pull request
Sep 26, 2023
k1LoW
added a commit
to k1LoW/testutil
that referenced
this pull request
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8 のissueを修正するコードを書いてみました。