Skip to content

Add Ubuntu Noble to integration-tests #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Ubuntu Noble to integration-tests #908

wants to merge 4 commits into from

Conversation

dklimpel
Copy link
Contributor

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

The current used images / Dockerfiles are EoL. Add a supported Ubuntu Noble image.

Check for run level does not work anymore.

noble:
  services:
    apache2: []

@dklimpel dklimpel mentioned this pull request May 10, 2024
Merged
3 tasks
@dklimpel dklimpel marked this pull request as ready for review May 10, 2024 20:06
@dklimpel dklimpel requested a review from aelsabbahy as a code owner May 10, 2024 20:06
@dklimpel dklimpel mentioned this pull request May 12, 2024
Open
@aelsabbahy
Copy link
Member

I think the new Ubuntu version doesn't use one of the supported service types for run levels:

https://github.com/goss-org/goss/blob/e73553f9c3065ac297499dafb4f8abef6acb24ad/docs/manual.md#service

runlevels is only supported on Alpine init, sysv init, and upstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelsabbahy aelsabbahy Awaiting requested review from aelsabbahy aelsabbahy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklimpel @aelsabbahy