fix outcome label in goss_tests_run_outcomes_total #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prometheus metric goss_tests_run_outcomes_total has a label called 'outcome' which suffers from two problems: 1) It won't be set to 'pass' in case all tests succeed 2) The order of test results determines the final value of the label, e.g. if there is a failed & skipped test then the outcome will be skipped, but if order of results is reversed the outcome will become failed. This commit fixes both by introducing a helper function which determines whether the outcome can be changed and adds tests to verify that behavior. fixes goss-org#789 Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
|
pinging @petemounce @timeu since you guys were involved in the original implementation |
|
From my point of view it looks good. Thanks for the fix |
aelsabbahy
approved these changes
Dec 12, 2023
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus metric goss_tests_run_outcomes_total has a label called 'outcome' which suffers from two problems:
This commit fixes both by introducing a helper function which determines whether the outcome can be changed and adds tests to verify that behavior.
fixes #789
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change