Skip to content

"socket" as one more valid filetype for "file" testing #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

"socket" as one more valid filetype for "file" testing #858

merged 1 commit into from
Nov 23, 2023

Conversation

fruit
Copy link
Contributor

@fruit fruit commented Nov 23, 2023

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Some files can be sockets. Goss detects already socket files correctly with filetype socket.

@fruit
socket as one more valid filetype
034b240 
Some files can be sockets. Goss detects socket files correctly with filetype `socket`.
@fruit fruit requested a review from aelsabbahy as a code owner November 23, 2023 22:06
@aelsabbahy aelsabbahy merged commit 9fa5ffb into goss-org:master Nov 23, 2023
@aelsabbahy
Copy link
Member

Great catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelsabbahy aelsabbahy Awaiting requested review from aelsabbahy aelsabbahy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruit @aelsabbahy