Fix: Set the Reportable flag in trap.IsInform messages #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimRots
requested changes
Jul 11, 2025
There was a problem hiding this comment.
Thank you for your first contribution @Naveenrajp26. Great bug you fixed there.
I left you some review comments to apply, then it's ready for further review.
TimRots
requested changes
Jul 14, 2025
…inetime and engineboots Signed-off-by: pavithra <naveenraj.pavithran@nokia.com>
Signed-off-by: pavithra <naveenraj.pavithran@nokia.com>
c8148ef to
60e6377
Compare
TimRots
approved these changes
Jul 16, 2025
|
@SuperQ I think this PR is ready for your re-view now. If adding tests would be blocking for you I can volunteer to handle that in a follow-up. |
SuperQ
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 3414 Section 4:
When sending an SNMPv3 InformRequest, the Reportable flag MUST be set in MsgFlags.
This ensures that the authoritative engine will return a Report PDU containing
engineBoots and engineTime for time synchronization which is required before
authenticated communication can succeed. Without this, the engine may reject
the Inform as out-of-time-window or unknown engine.