Skip to content

Added (t *TrapListener) WithBufferSize(i uint) *TrapListener #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

maniack
Copy link
Contributor

@maniack maniack commented May 27, 2025

Hello,

Would you like to review my changes and add a variable size snmp trap message buffer to your code, since in practice it turned out that many snmp trap and inform messages exceed the size of 4 KB.

Signed-off-by: maniack <i.a.lazarev@gmail.com>
@maniack maniack force-pushed the add-variable-buffer-to-trap-listener branch from ff51df5 to 35e6150 Compare May 27, 2025 08:49
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change the default buffer to 64KiB based on the UDP packet length limit.

Replaced with zero buffer check

Signed-off-by: maniack <i.a.lazarev@gmail.com>
@maniack maniack force-pushed the add-variable-buffer-to-trap-listener branch from 0031599 to 8ae1689 Compare May 27, 2025 10:39
Signed-off-by: maniack <i.a.lazarev@gmail.com>
@SuperQ SuperQ merged commit a48efea into gosnmp:master Jun 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants