Remove GoSNMP.NonRepeaters. #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lepage <daniel.lepage@datadoghq.com>
40bc5ad to
5b8969e
Compare
SuperQ
requested changes
Dec 19, 2024
| @@ -111,10 +111,6 @@ type GoSNMP struct { | |||
| // See comments in https://github.com/gosnmp/gosnmp/issues/100 | |||
| MaxRepetitions uint32 | |||
|
|
|||
| // NonRepeaters sets the GETBULK max-repeaters used by BulkWalk*. | |||
| // (default: 0 as per RFC 1905) | |||
There was a problem hiding this comment.
Rather than fully remove this, can you mark it Deprecated: This parameter is not used and ignored per Go syntax conventions?
We can keep the behavior change in walk.go, but keeping the struct field avoids breaking the API.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a value
.NonRepeatersdefined in gosnmp.go. The comment on this value is wrong - there is nomax-repeatersvalue defined by that RFC, onlymax-repetitions, which is set by.MaxRepetitions. In fact, what this attribute is setting is thenon-repeatersattribute, which is NOT something that makes sense as a global setting - it indicates how many of the oids provided in aGETBULKrequest should only have one value fetched, instead of bulk-fetchingmax-repetitionsOIDs starting at that point.In the only place this attribute is used, as part of walk.go, there is exactly one OID being passed in, and the whole point of using
GetBulkis that we want to fetch more than one value, so in this callnon-repeatersshould always be set to 0; it should not be configurable. Setting it to anything greater than zero simply means thatGetBulkwill now only fetch one value for that OID; if you want that behavior, you should be using.Walkinstead of.BulkWalk.So as a parameter, its sole behavior is to make
.BulkWalk*behave unexpectedly badly; it is not something that should exist.