Refactor netsnmp playback function to use an io.Reader #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unnecessary casting of byte slice to string by using a base64 stream decoder atop an io.Reader (the os.File). Make error handling a bit more granular. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Aug 7, 2024
* [CHANGE] Refactor netsnmp playback function to use an io.Reader #459 * [FEATURE] Support multiple security parameters for receiving SNMP V3 traps #457 * [ENHANCEMENT] netsnmp tests: tame overzealous file / dir permissions #458 Also update missing v1.37.0 changelog entries. Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Aug 7, 2024
* [CHANGE] Refactor netsnmp playback function to use an io.Reader #459 * [FEATURE] Support multiple security parameters for receiving SNMP V3 traps #457 * [ENHANCEMENT] netsnmp tests: tame overzealous file / dir permissions #458 Also update missing v1.37.0 changelog entries. Signed-off-by: SuperQ <superq@gmail.com>
vma
pushed a commit
to sipsolutions/gosnmp
that referenced
this pull request
May 6, 2025
Avoid unnecessary casting of byte slice to string by using a base64 stream decoder atop an io.Reader (the os.File). Make error handling a bit more granular. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary casting of byte slice to string by using a base64 stream decoder atop an io.Reader (the os.File). Make error handling a bit more granular.