Make InitPacket and InitSecurityKeys public #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
Sep 8, 2023
SuperQ
approved these changes
Sep 14, 2023
|
Instead of duplicating some existing logic, what are your thoughts on making the InitPacket() and usmAllocateNewSalt() methods public? It would be helpful to add clear documentation explaining their intent and possibly include some test cases. |
|
@TimRots I think I'll modify this PR to reflect this in a few days. |
TimRots
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Thank you for the updated PR @upsampled, this looks great to me.
If we can get consensus I think some comments would be needed to describe what InitPacket and InitSecurityKeys are doing?
@SuperQ what do you think ?
SuperQ
approved these changes
Sep 20, 2023
this allows external packages, like the GoSNMPServer, to use gosnmp to handle encrypted sessions. Signed-off-by: Liam Kelly <liam@commdevices.com>
TimRots
approved these changes
Sep 20, 2023
kajtzu
added a commit
to basen/gosnmp
that referenced
this pull request
Sep 28, 2023
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Nov 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/gosnmp/gosnmp](https://togithub.com/gosnmp/gosnmp) | require | minor | `v1.36.1` -> `v1.37.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gosnmp/gosnmp (github.com/gosnmp/gosnmp)</summary> ### [`v1.37.0`](https://togithub.com/gosnmp/gosnmp/releases/tag/v1.37.0) [Compare Source](https://togithub.com/gosnmp/gosnmp/compare/v1.36.1...v1.37.0) #### What's Changed - Make InitPacket and InitSecurityKeys public by [@​upsampled](https://togithub.com/upsampled) in [https://github.com/gosnmp/gosnmp/pull/447](https://togithub.com/gosnmp/gosnmp/pull/447) - Refactor TrapListener's Close Method by [@​TimRots](https://togithub.com/TimRots) in [https://github.com/gosnmp/gosnmp/pull/449](https://togithub.com/gosnmp/gosnmp/pull/449) - Allow RequestID to be shrunk if possible by [@​upsampled](https://togithub.com/upsampled) in [https://github.com/gosnmp/gosnmp/pull/451](https://togithub.com/gosnmp/gosnmp/pull/451) - Add net-snmp validation testing by [@​upsampled](https://togithub.com/upsampled) in [https://github.com/gosnmp/gosnmp/pull/452](https://togithub.com/gosnmp/gosnmp/pull/452) - Add fuzzing to CI by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/gosnmp/gosnmp/pull/444](https://togithub.com/gosnmp/gosnmp/pull/444) - Allow global password cache to be turned off by [@​upsampled](https://togithub.com/upsampled) in [https://github.com/gosnmp/gosnmp/pull/454](https://togithub.com/gosnmp/gosnmp/pull/454) - build(deps): bump github.com/google/go-cmp from 0.5.9 to 0.6.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gosnmp/gosnmp/pull/455](https://togithub.com/gosnmp/gosnmp/pull/455) #### New Contributors - [@​upsampled](https://togithub.com/upsampled) made their first contribution in [https://github.com/gosnmp/gosnmp/pull/447](https://togithub.com/gosnmp/gosnmp/pull/447) **Full Changelog**: gosnmp/gosnmp@v1.36.1...v1.37.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow GoSNMPServer to use mainline
gosnmp/gosnmpagain (along with some minimal changes to it).Closes: #446