unmarshal: fix panic from reading beyond slice #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding the example problem slice as a new unit test? |
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
Signed-off-by: n3integration <n3integration@users.noreply.github.com>
TimRots
approved these changes
Aug 28, 2023
|
No worries, hope you're feeling better. |
SuperQ
added a commit
that referenced
this pull request
Aug 28, 2023
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds #426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value #413 * [BUGFIX] Refactor security logger #422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call #425 * [BUGFIX] unmarshal: fix panic from reading beyond slice #441 Signed-off-by: SuperQ <superq@gmail.com>
Merged
vma
pushed a commit
to sipsolutions/gosnmp
that referenced
this pull request
May 6, 2025
This release now requires Go 1.20 or higher. * [ENHANCEMENT] Allow sending v1 traps that have no varbinds gosnmp#426 * [BUGFIX] Fix getBulk SnmpPacket MaxRepetitions value gosnmp#413 * [BUGFIX] Refactor security logger gosnmp#422 * [BUGFIX] Add privacy passphrase in extendKeyBlumenthal cacheKey call gosnmp#425 * [BUGFIX] unmarshal: fix panic from reading beyond slice gosnmp#441 Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #440
Expand the bounds check of the
packetbytes to prevent reading beyond the available number of bytes