Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gosnmp/gosnmp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.36.1
Choose a base ref
...
head repository: gosnmp/gosnmp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.37.0
Choose a head ref
  • 9 commits
  • 31 files changed
  • 5 contributors

Commits on Sep 20, 2023

  1. make InitPacket and InitSecurityKeys public

    this allows external packages, like the GoSNMPServer,  to use gosnmp to handle encrypted sessions.
    
    Signed-off-by: Liam Kelly <liam@commdevices.com>
    upsampled committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fe290d4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #447 from upsampled/upsampled-GoSNMPServer-Compat

    Make InitPacket and InitSecurityKeys public
    SuperQ authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9457f61 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Refactor TrapListener's Close Method (#449)

    - Ensure idempotent and thread-safe Close behavior.
    - Close connection for both TCP and UDP without protocol checks.
    - Use atomic operations for safer concurrent handling.
    - Await "done" signal before complete closure, ensuring clean shutdown.
    
    Fixes:
    - Address potential issue where the connection might not be closed in certain conditions
    
    Enhances:
    - Configurable TrapListener.CloseTimeout with a default of 3 seconds.
    
    Signed-off-by: Tim Rots <tim.rots@protonmail.ch>
    TimRots authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2708929 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Allow RequestID to be shrunk if possible, defer to asn1 package

    Signed-off-by: Liam Kelly <liam@commdevices.com>
    upsampled committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    c255f35 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #451 from upsampled/#450-RequestID-Shrink

    Allow RequestID to be shrunk if possible
    SuperQ authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    fc5b18e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Add net-snmp validation testing (#452)

    * Initial net-snmp validation testing
    
    running go test with -tags=netsnmp will cause the test to use packets generated by net-snmp as expected values. This requires libsnmpd to be installed and cgo. Adding -rec=true to this will also record the expected packets as files under /testdata. These files can then be used without cgo in normally testing.
    
    An additional pcap generating feature was also added, when -pcap $DIR is added to go test that directory will be filled with the expected and generated packets as pcaps. This allows for debugging using wireshark's parsers.
    
    * Counter32 support added to '*Gosnmp.Set' and validated
    * Add support Set support and validate most PDU types. Also add Uinteger32 parse support.
    
    Fixes: #453
    
    ---------
    
    Signed-off-by: Liam Kelly <liam@commdevices.com>
    upsampled authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ddcf553 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Add fuzzing to CI (#444)

    Add a 60s fuzzing test to the CI test pipeline.
    
    Signed-off-by: SuperQ <superq@gmail.com>
    SuperQ authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d306ed5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Allow global password cache to be turned off (#454)

    * Allow global password cache to be turned off
    
    The global password cache is undesirable for higher security applications as a user's cache entry would remain even if the calling package deleted the corresponding `UsmSecurityParameters`.
    
    Disabling this mechanism comes with a significant performance hit, as seen by running the added benchmark tests with the build tag `gosnmp_nopwdcache`.
    
    There is also a middle ground approach, where the calling package can reset the cache by turning it off then on again. This should clear any stale entries and still allow the cache to be leveraged.
    
    Signed-off-by: Liam Kelly <liam@commdevices.com>
    upsampled authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5d97775 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. build(deps): bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (#455)

    Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0.
    - [Release notes](https://github.com/google/go-cmp/releases)
    - [Commits](google/go-cmp@v0.5.9...v0.6.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/go-cmp
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4fb6a44 View commit details
    Browse the repository at this point in the history
Loading