feat(nacos): add configuration change notification functionality #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Degfy
commented
Jun 4, 2025
- Implement Notify method in configure struct to support configuration change callbacks
- Add newConf method to create and return a new viper instance for updated configurations- Update OnChange method to use the newConf method and handle configuration updates more efficiently
- Refactor Init method to use a newConfigClient variable for better code organization
- Improve error handling throughout the code using g.ErrorPrinter and g.PanicIfErr
- Update tests to cover new functionality and ensure proper behavior of configuration updates
- Implement Notify method in configure struct to support configuration change callbacks - Add newConf method to create and return a new viper instance for updated configurations- Update OnChange method to use the newConf method and handle configuration updates more efficiently - Refactor Init method to use a newConfigClient variable for better code organization - Improve error handling throughout the code using g.ErrorPrinter and g.PanicIfErr - Update tests to cover new functionality and ensure proper behavior of configuration updates
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.