Skip to content

Conversation

Degfy
Copy link
Member

@Degfy Degfy commented Jun 4, 2025

  • Add Notify method to apolloConfigure struct
  • Implement watch functionality in changeListener
  • Update tests to cover new functionality
  • Refactor error handling to use g.ErrorPrinter
  • Remove unused mock files

dapeng added 2 commits June 4, 2025 15:36
- Add Notify method to apolloConfigure struct
- Implement watch functionality in changeListener
- Update tests to cover new functionality
- Refactor error handling to use g.ErrorPrinter
- Remove unused mock files
- Add go-cmp package for deep comparison of arbitrary values
- Implement compare() function using go-cmp's Equal() method
- Replace simple equality check with compare() function in OnChange method
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
apollo/configure.go 95.52% <100.00%> (+3.97%) ⬆️
apollo/listener.go 98.07% <100.00%> (+15.57%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Degfy Degfy merged commit 76b638e into main Jun 4, 2025
6 checks passed
@Degfy Degfy added this to gone plan Jun 4, 2025
@Degfy Degfy moved this to Done in gone plan Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant