Skip to content

Conversation

Degfy
Copy link
Member

@Degfy Degfy commented Apr 20, 2025

  • Add new etcd registry implementation for service discovery
  • Refactor service registration and parsing logic
  • Update go.mod files to include new dependencies
  • Improve error handling and logging in registry operations

dapeng added 3 commits April 19, 2025 21:19
- Add new etcd registry implementation for service discovery
- Refactor service registration and parsing logic
- Update go.mod files to include new dependencies
- Improve error handling and logging in registry operations
…ad funcs

- Update gone-io/gone/mock/v2 to v2.0.12
- Update gone-io/gone/v2 to v2.0.12
- Update github.com/stretchr/testify to v1.10.0
- Refactor SingLoadProviderFunc and NamedThirdComponentLoadFunc to use built-in methods
- Improve Service struct and ParseService function- Add unit tests for ParseService
- Update github.com/gone-io/gone/v2 from v2.0.11 to v2.0.12
- Update github.com/gone-io/goner/g from v1.0.10 to v1.0.11
- Update other related dependencies in multiple modules
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 87.97468% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
etcd/client.go 40.00% 4 Missing and 2 partials ⚠️
consul/registry.go 60.00% 3 Missing and 1 partial ⚠️
consul/client.go 0.00% 2 Missing and 1 partial ⚠️
etcd/discovery.go 94.23% 2 Missing and 1 partial ⚠️
etcd/registry.go 94.33% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
etcd/load.go 100.00% <100.00%> (ø)
g/help.go 97.53% <100.00%> (+0.09%) ⬆️
g/service.go 100.00% <100.00%> (ø)
consul/client.go 86.36% <0.00%> (-13.64%) ⬇️
etcd/discovery.go 94.23% <94.23%> (ø)
etcd/registry.go 94.33% <94.33%> (ø)
consul/registry.go 75.00% <60.00%> (-0.73%) ⬇️
etcd/client.go 40.00% <40.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dapeng added 4 commits April 20, 2025 11:14
- Add strconv package import for safe string quoting
- Use strconv.Quote on JSON output to ensure proper formatting and safety
- Add unit tests for Registry using testify and mock
- Implement redoRegisterLease method for better error handling
- Update GetServerValue to use direct JSON marshaling
- Add etcd mock file for interface mocking
- Update go.mod and go.sum for new dependencies
- Add watcher interface to etcd mock
- Implement watch functionality in discovery.go
- Add unit tests for extractResponseToServices and watch
- Update load test to use correct parameters
- Refactor registry tests to cover new functionality
- Update log format for etcd put operation to use double quotes instead of backticks
- Improve readability and consistency of error and debug messages
dapeng added 3 commits April 20, 2025 16:26
- Modify `GetServerValue` function to encode JSON-marshaled instance data in base64- Update tests to use base64-encoded service values
- This change enhances security and compatibility by encoding sensitive information
- Use gone.SafeExecute to handle potential panics safely- Improve error handling in the GetInstances function call
…config and etcd.config

- Update ProvideConsulClient and ProvideEtecd3Client to support new configuration options
- Add README and README_CN files for both consul and etcd components
- Modify existing test files to accommodate new configuration options
@Degfy Degfy merged commit 8bafbd1 into main Apr 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant