-
Notifications
You must be signed in to change notification settings - Fork 1
feat(etcd): add etcd registry and refactor service registration #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Degfy
commented
Apr 20, 2025
- Add new etcd registry implementation for service discovery
- Refactor service registration and parsing logic
- Update go.mod files to include new dependencies
- Improve error handling and logging in registry operations
- Add new etcd registry implementation for service discovery - Refactor service registration and parsing logic - Update go.mod files to include new dependencies - Improve error handling and logging in registry operations
…ad funcs - Update gone-io/gone/mock/v2 to v2.0.12 - Update gone-io/gone/v2 to v2.0.12 - Update github.com/stretchr/testify to v1.10.0 - Refactor SingLoadProviderFunc and NamedThirdComponentLoadFunc to use built-in methods - Improve Service struct and ParseService function- Add unit tests for ParseService
- Update github.com/gone-io/gone/v2 from v2.0.11 to v2.0.12 - Update github.com/gone-io/goner/g from v1.0.10 to v1.0.11 - Update other related dependencies in multiple modules
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
- Add strconv package import for safe string quoting - Use strconv.Quote on JSON output to ensure proper formatting and safety
- Add unit tests for Registry using testify and mock - Implement redoRegisterLease method for better error handling - Update GetServerValue to use direct JSON marshaling - Add etcd mock file for interface mocking - Update go.mod and go.sum for new dependencies
- Add watcher interface to etcd mock - Implement watch functionality in discovery.go - Add unit tests for extractResponseToServices and watch - Update load test to use correct parameters - Refactor registry tests to cover new functionality
- Update log format for etcd put operation to use double quotes instead of backticks - Improve readability and consistency of error and debug messages
- Modify `GetServerValue` function to encode JSON-marshaled instance data in base64- Update tests to use base64-encoded service values - This change enhances security and compatibility by encoding sensitive information
- Use gone.SafeExecute to handle potential panics safely- Improve error handling in the GetInstances function call
…config and etcd.config - Update ProvideConsulClient and ProvideEtecd3Client to support new configuration options - Add README and README_CN files for both consul and etcd components - Modify existing test files to accommodate new configuration options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.