Fix duplicate and recursive footnotes #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the infinite loop when there is a self-refer footnote by checking if the reference is already added into parser.notes. It also fixes of creating duplicate footnotes through this modification. Add coresponding testcase. Original PR: russross/blackfriday#366 Fixes: mmarkdown/mmark#25 Signed-off-by: Miek Gieben <miek@miek.nl>
|
porting the test cases proved too tedious so I just took what the test wanted to see; at least the test didn't hang is it did before this fix. |
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 81.69% 81.72% +0.02%
==========================================
Files 21 21
Lines 3737 3743 +6
==========================================
+ Hits 3053 3059 +6
Misses 537 537
Partials 147 147
Continue to review full report at Codecov.
|
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the infinite loop when there is a self-refer footnote by checking if
the reference is already added into parser.notes.
It also fixes of creating duplicate footnotes through this modification.
Add coresponding testcase.
Original PR: russross/blackfriday#366
Fixes: mmarkdown/mmark#25
Signed-off-by: Miek Gieben miek@miek.nl