Add page context to template filter, resolves #1603 #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters accepting no parameters are still allowed for backward compatibility.
|
@dometto @bartkamphorst Please help to review, thank you! |
dometto
approved these changes
Apr 25, 2022
|
Thanks again @tevino! Could I ask you to document this feature in the wiki? |
|
@dometto Sure, that's a part of the feature, here it goes. Please feel free to polish and looking forward to seeing the release of this, cheers! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1612 is a great start to resolve #1603, it introduced the template filter.
This one is a step forward to allow accessing more context (namely
page.name) in a template filter, as described here: #1612 (comment)