Skip to content

unescape page names in the preview tab #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2021
Merged

unescape page names in the preview tab #1739

merged 2 commits into from
Aug 28, 2021

Conversation

yy0931
Copy link
Contributor

@yy0931 yy0931 commented Jul 12, 2021

I fixed a problem that non-ascii characters in page names are not rendered correctly in the preview tab of the "Edit" page. The change is to add decodeURIComponent() to location.pathname.

You can also see the same problem using a page name "C#".

before

@yy0931 yy0931 changed the title unescape page names unescape page names in the preview tab Jul 12, 2021
@bartkamphorst
Copy link
Member

Looks good to me. 👍 @dometto ?

@dometto
Copy link
Member

dometto commented Jul 12, 2021

Agreed! Thanks again @yy0931

@bartkamphorst bartkamphorst merged commit cbcbc4b into gollum:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants