Skip to content

Fix an IME rendering issue #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Fix an IME rendering issue #1735

merged 2 commits into from
Jul 9, 2021

Conversation

yy0931
Copy link
Contributor

@yy0931 yy0931 commented Jul 7, 2021

I fixed a problem that occurs when inputting Japanese (and probably Chinese etc.). It is caused by a padding setting applied to .form-control, .form-select in primer.css overriding the ace editor's style.
I also replaced File with ::File in lib/gollum.rb because they throwed errors during bundle exec rake precompile.

before:
before

after:
after

Copy link
Member

@benjaminwil benjaminwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for including the before/after example.

@dometto
Copy link
Member

dometto commented Jul 9, 2021

Thanks @yy0931! Looks good.

@benjaminwil benjaminwil merged commit 046353c into gollum:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants