unix: add ClockSettime on Linux #221

yarikk · 2024-10-10T00:22:49Z

The syscall clock_settime(3) is used to set the time on the specified
clock. It is a counterpart to clock_gettime(3) which is already
exposed as ClockGettime here.

Fixes golang/go#69830

gopherbot · 2024-10-10T00:34:45Z

This PR (HEAD: 3bed027) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/619255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

The syscall clock_settime(3) is used to set the time on the specified clock. It is a counterpart to clock_gettime(3) which is already exposed as ClockGettime here. Fixes golang/go#69830

gopherbot · 2024-10-10T00:41:39Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:41:40Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:41:43Z

This PR (HEAD: 5b15f12) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/619255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-10T00:48:33Z

Message from Ian Lance Taylor:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:48:34Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-10T00:41:30Z","revision":"36017d0205ddd3291db69f0fc96f6eae85b596ac"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:48:35Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 2 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:48:35Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-10T00:41:41Z","revision":"d7e3c10bc03db8372915dfce00696aa6b367b1f7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:48:36Z

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:14Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:14Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-10T00:42:18Z","revision":"d7e3c10bc03db8372915dfce00696aa6b367b1f7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:15Z

Message from Yaroslav Kolomiiets:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:15Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:16Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T00:55:16Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T01:22:12Z

Message from Yaroslav Kolomiiets:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T04:12:09Z

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T04:18:48Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-10T04:06:54Z","revision":"d7e3c10bc03db8372915dfce00696aa6b367b1f7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T04:25:39Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T04:25:39Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/619255.
After addressing review feedback, remember to publish your drafts!

The syscall clock_settime(3) is used to set the time on the specified clock. It is a counterpart to clock_gettime(3) which is already exposed as ClockGettime here. Fixes golang/go#69830 Change-Id: I6145c915754f31e3c50f6a11568eb9d5ba12a778 GitHub-Last-Rev: 5b15f12 GitHub-Pull-Request: #221 Reviewed-on: https://go-review.googlesource.com/c/sys/+/619255 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-10-10T20:01:32Z

This PR is being closed because golang.org/cl/619255 has been merged.

unix: add ClockSettime on Linux

5b15f12

The syscall clock_settime(3) is used to set the time on the specified clock. It is a counterpart to clock_gettime(3) which is already exposed as ClockGettime here. Fixes golang/go#69830

gopherbot closed this Oct 10, 2024

unix: add ClockSettime on Linux #221

unix: add ClockSettime on Linux #221

Uh oh!

Conversation

yarikk commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

gopherbot commented Oct 10, 2024

Uh oh!

Uh oh!

yarikk commented Oct 10, 2024 •

edited

Loading