Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.21.0
Choose a base ref
...
head repository: golang/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.0
Choose a head ref
  • 6 commits
  • 15 files changed
  • 4 contributors

Commits on Jun 13, 2024

  1. windows/svc: do not pass theService to windows.RegisterServiceCtrlHan…

    …dlerEx
    
    windows.RegisterServiceCtrlHandlerEx context parameter is uintptr, so it
    is unsafe to pass pointers in that parameter. Use theService global
    variable in ctlHandler function instead.
    
    Fixes golang/go#67437
    
    Change-Id: I84c910eaa354603c2a5114421cd61788cb40b86f
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/591475
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
    Reviewed-by: David Chase <drchase@google.com>
    alexbrainman committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    348425a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. windows: add GetAce Windows API

    GetAce obtains a pointer to an access control entry (ACE) in an
    discretionary access control list (DACL), which controls access to
    an object.
    
    Adds the ACE_HEADER and ACCESS_ALLOWED_ACE structs.
    Adds GetEntriesFromACL function which returns an array of ACEs from the
    given ACL if no errors have been encountered.
    
    References:
    
    - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-ace_header
    - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-access_allowed_ace
    - https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-getace
    
    Fixes golang/go#66850
    
    Change-Id: I98306ff7e947e586a58d563d364169a2555492f4
    GitHub-Last-Rev: d14ca7f
    GitHub-Pull-Request: #191
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/578976
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    claudiubelu authored and neild committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7670087 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. unix: add unsafe mmap, munmap, mremap

    Fixes golang/go#56123
    
    Change-Id: I63a7a6fb3a5b1bb556ac19d76a1e0b04a03ebcfa
    GitHub-Last-Rev: 39dbc8e
    GitHub-Pull-Request: #197
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/592415
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    ncruces authored and gopherbot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    daa2394 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. unix: fix MremapPtr test failing on NetBSD

    NetBSD apparently doesn't allow remapping into used address space.
    This means that the test that uses mremap to move a mmapped page
    into a new address should first mmap (to reserve)
    then munmap (to free) the destination.
    
    Fixes golang/go#68180
    
    Change-Id: If66b67e7166ca4dc4331a8cfc3e3a285416e9849
    GitHub-Last-Rev: 92058c2
    GitHub-Pull-Request: #198
    Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-amd64
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/594756
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Joedian Reid <joedian@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    ncruces authored and gopherbot committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a0ef40a View commit details
    Browse the repository at this point in the history
  2. unix: fix MmapPtr test failing on OpenBSD

    OpenBSD apparently doesn't allow unmapping address space if part of the region is already unmapped.
    This tweaks the test so that munmapping twice no longer happens.
    
    Fixes golang/go#68181
    
    Change-Id: I588255f5e10ec015dbb7188eac79cee6be570680
    GitHub-Last-Rev: 2535abd
    GitHub-Pull-Request: #199
    Cq-Include-Trybots: luci.golang.try:go1.22-openbsd-amd64
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/595095
    TryBot-Bypass: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@golang.org>
    ncruces authored and gopherbot committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c892bb7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. unix: add PthreadChdir and PthreadFchdir on darwin

    Fixes golang/go#68226
    
    Change-Id: I92052e2319e4edde21b5e1e47ddb5b261d81448a
    GitHub-Last-Rev: bc02d6d
    GitHub-Pull-Request: #201
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/595677
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    espadolini authored and gopherbot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    faed7ec View commit details
    Browse the repository at this point in the history
Loading