Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.0
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.14.0
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 2, 2025

  1. errgroup: document calling Go before Wait

    Fixes golang/go#70284
    
    Change-Id: I31d60ea182226c032b0ffbddcbb5b53675dfd5e6
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/660075
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    seankhliao authored and gopherbot committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    396f3a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. errgroup: propagate panic and Goexit through Wait

    Recovered panic values are wrapped and saved in Group.
    Goexits are detected by a sentinel value set after the given function
    returns normally. Wait propagates the first instance of a panic or
    Goexit.
    
    According to the runtime.Goexit after the code will not be executed,
    with a bool, if f not call runtime.Goexit, is true,
    determine whether to propagate runtime.Goexit.
    
    Fixes golang/go#53757
    
    Change-Id: Ic6426fc014fd1c4368ebaceef5b0d6163770a099
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/644575
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Commit-Queue: Alan Donovan <adonovan@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    qiulaidongfeng authored and gopherbot committed Apr 7, 2025
    Configuration menu
    Copy the full SHA
    506c70f View commit details
    Browse the repository at this point in the history
Loading