Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.30.0
Choose a head ref
  • 14 commits
  • 22 files changed
  • 8 contributors

Commits on Jun 12, 2024

  1. http2: avoid Transport hang with Connection: close and AllowHTTP

    CL 111835 changed Transport stream ID numbering to start at
    stream 3 when AllowHTTP is set. This was based on a
    misunderstanding:
    
    When a connection upgrades an HTTP/1.1 request to HTTP/2,
    the initial HTTP/1.1 request occupies stream 1.
    However, Transport does not perform HTTP protocol upgrades.
    When using a Transport to send unencrypted HTTP/2 requests,
    the entire connection uses HTTP/2, the first request is
    sent as HTTP/2, and there is no reason not to use stream 1
    for this request.
    
    Starting from stream 3 is mostly harmless,
    but ClientConn.idleStateLocked assumes that client streams
    start from 1. This causes it to misidentify new single-use
    connections as having already sent a request (when AllowHTTP
    is set), and therefore not suitable for use.
    
    Revert to always starting stream IDs at 1.
    
    Fixes golang/go#67671
    
    Change-Id: I97c89de4ae49623d916f9dbd200f8252d2fd4247
    Reviewed-on: https://go-review.googlesource.com/c/net/+/591275
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    neild committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9617c63 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. quic: skip tests which depend on unimplemented UDP functions on Plan 9

    The ReadMsgUDP and WriteMsgUDP methods of UDPConn are not implemented
    (yet?) on Plan 9. Skip tests which require them.
    
    Fixes golang/go#68288
    
    Change-Id: Ic6c81b19322d589c10b16da61e9b89284294be05
    Reviewed-on: https://go-review.googlesource.com/c/net/+/596795
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    millerresearch authored and thanm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    77708f7 View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ibb0ab46488252d035430a654eed5dd4caab7509e
    Reviewed-on: https://go-review.googlesource.com/c/net/+/596895
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    gopherbot committed Jul 5, 2024
    2 Configuration menu
    Copy the full SHA
    e2310ae View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. LICENSE: update per Google Legal

    Very minor tweaks:
     - Remove (c) pseudosymbol.
     - Remove "All Rights Reserved."
     - Change "Google Inc." (no longer exists) to "Google LLC".
    
    [git-generate]
    echo '
    ,s/\(c\) //
    ,s/ All rights reserved.//
    ,s/Google Inc./Google LLC/
    w
    q
    ' | sam -d LICENSE
    
    Change-Id: Ibaa49e00dd08950a577e4343bfc574980d327995
    Reviewed-on: https://go-review.googlesource.com/c/net/+/598579
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    rsc committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    032e4e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. xsrftoken: create no padding base64 string by RawURLEncoding

    The XSRF token generation function creates the padded base64 string by
    base64.URLEncoding, then removes the padding. It is equivalent to the
    base64.RawURLEncoding but with more costs.
    
    Change-Id: I9cf5ad94e9cf3dca9bbfc1b6818ab07d41acf417
    GitHub-Last-Rev: a8263b5
    GitHub-Pull-Request: #217
    Reviewed-on: https://go-review.googlesource.com/c/net/+/599895
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Damien Neil <dneil@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    ghosind authored and gopherbot committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    765c7e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I6a2e43cca79f719c018887e1d75b578fc27be8f1
    Reviewed-on: https://go-review.googlesource.com/c/net/+/603399
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4542a42 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. websocket: fix printf(var) mistake detected by latest printf checker

    For golang/go#69267.
    
    Change-Id: Ica6d123312495966ad6d222d67944fd602216853
    Reviewed-on: https://go-review.googlesource.com/c/net/+/610799
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    dmitshur authored and gopherbot committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9bf379f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I4be730755989f3d982deaac30cf72c1f3546d4b7
    Reviewed-on: https://go-review.googlesource.com/c/net/+/611198
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    gopherbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    35b4aba View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. route: fix address parsing of messages on Darwin

    sizeofSockaddrInet is 16, but first byte of sockaddr specifies actual
    size of sockaddr.
    
    Although, 16 works for most cases, it fails for Netmasks addresses. On
    Darwin only the significant bits of the netmask are in the msg.
    
    Take this route message as an example
    
    ```
    // rt_msg_hdr
    88 00 05 01 00 00 00 00
    41 08 00 00 07 00 00 00
    92 7b 00 00 01 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00
    
    // metrics
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    00 00 00 00 00 00 00 00
    
    // SOCKADDRS - DST  (100.113.0.0)
    10 02 00 00 64 71 00 00
    00 00 00 00 00 00 00 00
    
    // GW  utun4319
    14 12 21 00 01 08 00 00
    75 74 75 6e 34 33 31 39
    00 00 00 00
    
    // NETMASK 255.255.0.0
    06 02 00 00 ff ff
    
    // NULL
    00 00
    ```
    
    i.e. ipv4
    ```
    06 02 00 00 ff ff
    ```
    
    The above byte sequence is for a sockaddr that is 6 bytes long
    representing an ipv4 for address that is 255.255.0.0.
    
    i.e. ipv6 netmask
    ```
    0e 1e 00 00 00 00 00 00 ff ff ff ff ff ff 00 00
    ```
    
    The above is `/48` netmask that should also be parsed using `b[0]` of the
    sockaddr that contains the length.
    
    Confirmed by using `route monitor`.
    
    sources:
    https://github.com/apple/darwin-xnu/blob/main/bsd/net/route.h
    https://github.com/apple/darwin-xnu/blob/main/bsd/sys/socket.h#L603
    
    Fixes golang/go#44740
    
    Change-Id: I8153130d02d0a5e547fbf60a85762d3889e1d08c
    GitHub-Last-Rev: f7b9253
    GitHub-Pull-Request: #220
    Reviewed-on: https://go-review.googlesource.com/c/net/+/609577
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    hurricanehrndz authored and gopherbot committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3c333c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. http2: add Server.WriteByteTimeout

    Transports support a WriteByteTimeout option which sets the maximum
    amount of time we can go without being able to write any bytes to
    a connection. Add an equivalent option to Server for consistency.
    
    Fixes golang/go#61777
    
    Change-Id: Iaa8a69dfc403906eb224829320f901e5a6a5c429
    Reviewed-on: https://go-review.googlesource.com/c/net/+/601496
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    neild committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    541dbe5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. http2: add support for server-originated pings

    Add configurable support for health-checking idle connections
    accepted by the HTTP/2 server, following the same configuration
    as the Transport.
    
    Fixes golang/go#67812
    
    Change-Id: Ia4014e691546b2c29db8dad3af5f39966d0ceb93
    Reviewed-on: https://go-review.googlesource.com/c/net/+/601497
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    neild committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4790dc7 View commit details
    Browse the repository at this point in the history
  2. http2: add support for net/http HTTP2 config field

    For golang/go#67813
    
    Change-Id: I6b7f857d6ed250ba8b09649730980a91b3e8d7e9
    Reviewed-on: https://go-review.googlesource.com/c/net/+/607255
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    neild committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7191757 View commit details
    Browse the repository at this point in the history
  3. websocket: update nhooyr.io/websocket to github.com/coder/websocket

    Maintenance of nhooyr.io/websocket has moved to github.com/coder/websocket.
    
    Read more about the transition at https://coder.com/blog/websocket
    
    Updates golang/go#18152
    
    Change-Id: Ia2b11c9a57ad7ded775b50a5bbb7ea91562d39b5
    GitHub-Last-Rev: 59cea5e
    GitHub-Pull-Request: #222
    Reviewed-on: https://go-review.googlesource.com/c/net/+/614075
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    mafredri authored and gopherbot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f88258d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I57613519f6e5795e60d258865e81f6954d672606
    Reviewed-on: https://go-review.googlesource.com/c/net/+/617959
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    gopherbot committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6cc5ac4 View commit details
    Browse the repository at this point in the history
Loading