Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.0
Choose a head ref
  • 16 commits
  • 28 files changed
  • 9 contributors

Commits on Jan 5, 2023

  1. nettest: fix tests on dragonfly and js/wasm

    CL 458096 changes probeStack to use a better approach for checking
    network stack capability, by checking for routable ipv4/ipv6. However,
    the NewLocalListener needs check for listenable instead.
    
    This CL adds to probestack the listenable on loopback and use that
    condition instead.
    
    Fixes golang/go#57623
    
    Change-Id: I8b5b7798ccf3826881e5ef9f7d2d998d8e52eba5
    Reviewed-on: https://go-review.googlesource.com/c/net/+/460735
    Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    cuonglm authored and gopherbot committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f8411da View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. http2: case insensitive handling for 100-continue

    rfc 9110, section 10.1.1 states that the Expect field value is
    case-insensitive.
    
    Fixes golang/go#57824
    
    Change-Id: Ie0e2662c58a2933087e0d35935c04ec61026a41d
    Reviewed-on: https://go-review.googlesource.com/c/net/+/463096
    Auto-Submit: Damien Neil <dneil@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    fraenkel authored and gopherbot committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    296f09a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. all: correct typos in comments

    Change-Id: Idc75240e5546be2f2b091878910339b4967c93c7
    GitHub-Last-Rev: c78560c
    GitHub-Pull-Request: #166
    Reviewed-on: https://go-review.googlesource.com/c/net/+/465715
    Run-TryBot: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    alexandear authored and gopherbot committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7e3c19c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. all: fix some comments

    Change-Id: Iee11c27052222f017b672c06ced9e129ee51619c
    Reviewed-on: https://go-review.googlesource.com/c/net/+/465996
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Run-TryBot: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    cuishuang authored and gopherbot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    415cb6d View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: Ia50695ab9c32268c5dfa5096e448c6d7cca851bd
    Reviewed-on: https://go-review.googlesource.com/c/net/+/466595
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    gopherbot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    87ce33e View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. html: parse comments per HTML spec

    Updates golang/go#58246
    
    Change-Id: Iaba5ed65f5d244fd47372ef0c08fc4cdb5ed90f9
    Reviewed-on: https://go-review.googlesource.com/c/net/+/466776
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Run-TryBot: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <nigeltao@google.com>
    nigeltao authored and gopherbot committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    39940ad View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. http2: avoid referencing ResponseWrite.Write parameter after returning

    When writing data frames, encode the frame on the serve goroutine
    rather than in writeFrameAsync to avoid referencing stream data
    (originating from a ResponseWriter.Write call) after the Write
    has returned.
    
    Fixes golang/go#58446
    
    Change-Id: I866a7351c90ef122e506b333151f98a455a64953
    Reviewed-on: https://go-review.googlesource.com/c/net/+/467355
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    neild committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    547e7ed View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. http2/hpack: avoid quadratic complexity in hpack decoding

    When parsing a field literal containing two Huffman-encoded strings,
    don't decode the first string until verifying all data is present.
    Avoids forced quadratic complexity when repeatedly parsing a partial
    field, repeating the Huffman decoding of the string on each iteration.
    
    Thanks to Philippe Antoine (Catena cyber) for reporting this issue.
    
    Fixes golang/go#57855
    Fixes CVE-2022-41723
    
    Change-Id: I58a743df450a4a4923dddd5cf6bb0592b0a7bdf3
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1688184
    TryBot-Result: Security TryBots <security-trybots@go-security-trybots.iam.gserviceaccount.com>
    Reviewed-by: Julie Qiu <julieqiu@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Roland Shoemaker <bracewell@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/net/+/468135
    Run-TryBot: Michael Pratt <mpratt@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    neild authored and prattmic committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8e2b117 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. html: add "Microsoft Outlook comment" tests

    This only adds new tests. A follow-up commit will change behavior.
    
    Updates golang/go#58246
    
    Change-Id: I6adf5941d5cfd3c28f7b9328882ac280109ee028
    Reviewed-on: https://go-review.googlesource.com/c/net/+/469055
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Kunpei Sakai <namusyaka@gmail.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    nigeltao committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    569fe81 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. html: have Render escape comments less often

    Fixes golang/go#58246
    
    Change-Id: I3effbd2afd7e363a42baa4db20691e57c9a08389
    Reviewed-on: https://go-review.googlesource.com/c/net/+/469056
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Reviewed-by: Kunpei Sakai <namusyaka@gmail.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    nigeltao committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    1d46ed8 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. hmtl: add security section to package comment

    Adds a short security considerations paragraph to the package comment
    detailing the differences between the parser and tokenizer.
    
    Change-Id: I9e6840b20f82ffc6bc4088fffd6b4eda97550c0a
    Reviewed-on: https://go-review.googlesource.com/c/net/+/459676
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
    rolandshoemaker committed Mar 3, 2023
    2 Configuration menu
    Copy the full SHA
    8c4ef2f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: Id9c6666c1b6cc671576285bf13d3ae7da8e2a168
    Reviewed-on: https://go-review.googlesource.com/c/net/+/473437
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    gopherbot committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    dfa2b5d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. html: fix package doc typo

    Change-Id: Ic16f297e936cf10bafe0656f5db68cd422c430aa
    Reviewed-on: https://go-review.googlesource.com/c/net/+/474217
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    rolandshoemaker authored and gopherbot committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    08dda57 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. http2: properly discard data received after request/response body is …

    …closed
    
    A server handler can close an inbound Request.Body to indicate that it
    is not interested in the remainder of the request body.
    
    Equivalently, a client can close a Response.Body indicate that it is
    not interesed in the remainder of the response body.
    
    In both cases, if we receive DATA frames from the peer for the stream,
    we should return connection-level flow control credit for the discarded data.
    We do not return stream-level flow control, since we don't want to unblock
    further sends of data that we're just going to discard.
    
    Closing either a Response.Body or an inbound Request.Body results in a
    pipe.BreakWithError. Reads from a broken pipe fail immediately.
    
    Previously, writes to a broken pipe would succeed, discarding the written
    data and incrementing the pipe's unread count. Silently discarding
    data written to a broken pipe results in both the Transport and Server
    failing to detect the condition where data has been discarded.
    
    Change pipes to return an error when writing to a broken pipe.
    
    Change transportResponseBody.Close to break the response body before
    returning flow control credit for unread data in the pipe, avoiding
    a race condition where data is added to the pipe in between the
    return of flow control credit and the pipe breaking.
    
    Change the Server to treat an error writing to the inbound request
    body as an expected condition (since this only happens when a
    handler closes the request body), returning connection-level
    flow control credit for the discarded data.
    
    Fixes golang/go#57578
    
    Change-Id: I1ed4ea9865818f9c7d7eb4500edfd7556e3cbcbf
    Reviewed-on: https://go-review.googlesource.com/c/net/+/475135
    Run-TryBot: Damien Neil <dneil@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    neild committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9f24bb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. http2: log the correct error when retrying in (*Transport).RoundTripOpt

    On the shouldRetryRequest path, err is invariantly nil, and therefore
    meaningless to log with vlogf. Instead, log the original error returned
    by the call to cc.RoundTrip.
    
    For golang/go#59155.
    
    Change-Id: I82c00a6033d0e92c28a5ccf60a87eec1c8b41886
    Reviewed-on: https://go-review.googlesource.com/c/net/+/477876
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Bryan C. Mills authored and gopherbot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6960703 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: I2fd2e05ca8edb122059be1918e555952de4941e8
    Reviewed-on: https://go-review.googlesource.com/c/net/+/482776
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    gopherbot committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    694cff8 View commit details
    Browse the repository at this point in the history
Loading