Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.7.0
Choose a head ref
  • 13 commits
  • 31 files changed
  • 9 contributors

Commits on Dec 10, 2022

  1. http2: fix race in TestCanonicalHeaderCacheGrowth

    As Damien found in the 2nd patch set of CL 455736 and CL 455735,
    disableGoroutineTracking is racy (but only called by benchmarks
    that don't care); set the serverConn.serveG in the test instead.
    
    Fixes golang/go#57218.
    
    Change-Id: I5e39be3c7fbac93260a26951491863b06b39d672
    Reviewed-on: https://go-review.googlesource.com/c/net/+/456523
    Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    dmitshur authored and gopherbot committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    e1ec361 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. websocket: don't recommend Gorilla

    It's no longer maintained.
    
    Fixes golang/go#57228
    
    Change-Id: I6678d1959a36761477e5c634c21305f775c80761
    Reviewed-on: https://go-review.googlesource.com/c/net/+/457356
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Ian Lance Taylor <iant@golang.org>
    ianlancetaylor authored and gopherbot committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    ad92d3d View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. nettest: use RoutedInterface for probing network stack capability

    The ipv4/ipv6 support capability is done by explicitly listening on
    loopback interface. However, it can lead to false positive, especially
    for ipv6 case. For example, ipv6 can be enabled, but explicitly disable
    for loopback interface (for security, policy ...).
    
    This CL changes probeStack to use another approach, by looking for any
    interface that can route IP traffic and in "UP" state. If there's one,
    then the platform can do ipv4/ipv6 networking functionality.
    
    Fixes golang/go#57386
    
    Change-Id: If911bc223b52c5a4562d3f61b4ee1032bdbec47c
    Reviewed-on: https://go-review.googlesource.com/c/net/+/458096
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    Reviewed-by: Benny Siegert <bsiegert@gmail.com>
    Reviewed-by: Matt Layher <mdlayher@gmail.com>
    Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    Reviewed-by: David Chase <drchase@google.com>
    cuonglm authored and gopherbot committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    2aa8215 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. http2: rewrite inbound flow control tracking

    Add a new inflow type for tracking inbound flow control.
    An inflow tracks both the window sent to the peer, and the
    window we are willing to send. Updates are accumulated and
    sent in a batch when the unsent window update is large
    enough.
    
    This change makes both the client and server use the same
    algorithm to decide when to send window updates. This should
    slightly reduce the rate of updates sent by the client, and
    significantly reduce the rate sent by the server.
    
    Fix a client flow control tracking bug: When processing data
    for a canceled stream, the record of flow control consumed
    by the peer was not updated to account for the discard
    stream.
    
    Fixes golang/go#28732
    Fixes golang/go#56558
    
    Change-Id: Id119d17b84b46f3dc2719f28a86758d9a10085d9
    Reviewed-on: https://go-review.googlesource.com/c/net/+/448155
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    neild committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    7805fdc View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: If285315dc2bfe895bc8079ec3943fe4194e20425
    Reviewed-on: https://go-review.googlesource.com/c/net/+/460499
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    gopherbot committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    8e0e7d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. nettest: fix tests on dragonfly and js/wasm

    CL 458096 changes probeStack to use a better approach for checking
    network stack capability, by checking for routable ipv4/ipv6. However,
    the NewLocalListener needs check for listenable instead.
    
    This CL adds to probestack the listenable on loopback and use that
    condition instead.
    
    Fixes golang/go#57623
    
    Change-Id: I8b5b7798ccf3826881e5ef9f7d2d998d8e52eba5
    Reviewed-on: https://go-review.googlesource.com/c/net/+/460735
    Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    cuonglm authored and gopherbot committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f8411da View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. http2: case insensitive handling for 100-continue

    rfc 9110, section 10.1.1 states that the Expect field value is
    case-insensitive.
    
    Fixes golang/go#57824
    
    Change-Id: Ie0e2662c58a2933087e0d35935c04ec61026a41d
    Reviewed-on: https://go-review.googlesource.com/c/net/+/463096
    Auto-Submit: Damien Neil <dneil@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    fraenkel authored and gopherbot committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    296f09a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. all: correct typos in comments

    Change-Id: Idc75240e5546be2f2b091878910339b4967c93c7
    GitHub-Last-Rev: c78560c
    GitHub-Pull-Request: #166
    Reviewed-on: https://go-review.googlesource.com/c/net/+/465715
    Run-TryBot: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    alexandear authored and gopherbot committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7e3c19c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. all: fix some comments

    Change-Id: Iee11c27052222f017b672c06ced9e129ee51619c
    Reviewed-on: https://go-review.googlesource.com/c/net/+/465996
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Run-TryBot: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    cuishuang authored and gopherbot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    415cb6d View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: Ia50695ab9c32268c5dfa5096e448c6d7cca851bd
    Reviewed-on: https://go-review.googlesource.com/c/net/+/466595
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    gopherbot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    87ce33e View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. html: parse comments per HTML spec

    Updates golang/go#58246
    
    Change-Id: Iaba5ed65f5d244fd47372ef0c08fc4cdb5ed90f9
    Reviewed-on: https://go-review.googlesource.com/c/net/+/466776
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Run-TryBot: Nigel Tao <nigeltao@golang.org>
    Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <nigeltao@google.com>
    nigeltao authored and gopherbot committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    39940ad View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. http2: avoid referencing ResponseWrite.Write parameter after returning

    When writing data frames, encode the frame on the serve goroutine
    rather than in writeFrameAsync to avoid referencing stream data
    (originating from a ResponseWriter.Write call) after the Write
    has returned.
    
    Fixes golang/go#58446
    
    Change-Id: I866a7351c90ef122e506b333151f98a455a64953
    Reviewed-on: https://go-review.googlesource.com/c/net/+/467355
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    neild committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    547e7ed View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. http2/hpack: avoid quadratic complexity in hpack decoding

    When parsing a field literal containing two Huffman-encoded strings,
    don't decode the first string until verifying all data is present.
    Avoids forced quadratic complexity when repeatedly parsing a partial
    field, repeating the Huffman decoding of the string on each iteration.
    
    Thanks to Philippe Antoine (Catena cyber) for reporting this issue.
    
    Fixes golang/go#57855
    Fixes CVE-2022-41723
    
    Change-Id: I58a743df450a4a4923dddd5cf6bb0592b0a7bdf3
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1688184
    TryBot-Result: Security TryBots <security-trybots@go-security-trybots.iam.gserviceaccount.com>
    Reviewed-by: Julie Qiu <julieqiu@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Roland Shoemaker <bracewell@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/net/+/468135
    Run-TryBot: Michael Pratt <mpratt@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    neild authored and prattmic committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8e2b117 View commit details
    Browse the repository at this point in the history
Loading