Skip to content

all: replace io/ioutil with io and os package #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

all: replace io/ioutil with io and os package #17

wants to merge 3 commits into from

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 16, 2023 •
edited
Loading

This PR replaces the deprecated in Go 1.17 io/ioutil package with io and os packages.

Changes are the same as in CL 430799 but with test fixes.

@alexandear
all: replace io/ioutil with io and os package
a66951f 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: a66951f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/462278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 251a5e1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/462278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: e5348f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/462278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 28cdff9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/462278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2023 •
edited
Loading

There are unresolved comments on the Gerrit review. If this is ready for another code review, please mark the Gerrit comments as resolved. Thanks.

@alexandear
Copy link
Contributor Author

alexandear commented Jan 23, 2023 •
edited
Loading

image

@bcmills Sorry, but Gerrit tells me that all comments are resolved. Am I missing something?

@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2023

You have 4 unpublished drafts. (Use the Reply button to send them.)

gopherbot pushed a commit that referenced this pull request Jan 23, 2023
@alexandear @gopherbot
all: replace io/ioutil with io and os package
a42224d 
This PR replaces the deprecated in Go 1.17 `io/ioutil` package with `io` and `os` packages.

Changes are the same as in [CL 430799](https://go.dev/cl/430799) but with test fixes.

Change-Id: I69095e5d62b10879fd273305876fd7498803705d
GitHub-Last-Rev: 28cdff9
GitHub-Pull-Request: #17
Reviewed-on: https://go-review.googlesource.com/c/mod/+/462278
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
@gopherbot
Copy link
Contributor

Message from Oleksandr Redko:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/462278 has been merged.

@gopherbot gopherbot closed this Jan 23, 2023
@alexandear alexandear deleted the all-remove-ioutil branch January 23, 2023 16:10
@alexandear alexandear mentioned this pull request Feb 2, 2023
Closed
kailee55n added a commit to kailee55n/go_mod that referenced this pull request May 8, 2025
@kailee55n
all: replace io/ioutil with io and os package
a6a0c21 
This PR replaces the deprecated in Go 1.17 `io/ioutil` package with `io` and `os` packages.

Changes are the same as in [CL 430799](https://go.dev/cl/430799) but with test fixes.

Change-Id: I69095e5d62b10879fd273305876fd7498803705d
GitHub-Last-Rev: 28cdff9b8c971556da0006d955d60551930cebde
GitHub-Pull-Request: golang/mod#17
Reviewed-on: https://go-review.googlesource.com/c/mod/+/462278
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @gopherbot @bcmills