x/sys/unix: missing ETHTOOL_FLAG_ constants in v0.23.0 #68761
Description
Go version
go version go1.22.5 linux/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/smira/.cache/go-build'
GOENV='/home/smira/.config/go/env'
GOEXE=''
GOEXPERIMENT='loopvar'
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/smira/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/smira/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/smira/sdk/go1.22.5'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/smira/sdk/go1.22.5/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/smira/Documents/image-factory/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1214322846=/tmp/go-build -gno-record-gcc-switches'What did you do?
Tried to run e.g. https://github.com/mdlayher/ethtool/blob/main/client_linux.go#L567 with golang.org/x/sys v0.23.0
What did you see happen?
In the commit https://cs.opensource.google/go/x/sys/+/31ef9e726f987c593d73c3c35ca1c7477cf0e480, the constants
ETHTOOL_FLAG_* were removed (https://cs.opensource.google/go/x/sys/+/31ef9e726f987c593d73c3c35ca1c7477cf0e480:unix/zerrors_linux.go;dlc=d03a807229bc212694753d74c81119a9b4adb711).
What did you expect to see?
The constants to stay :)