Skip to content

x/tools/gopls: improvements to package renaming #56184

@findleyr

Description

@findleyr

This issue tracks improvements to package renaming that we are aiming to land in gopls@v0.11.0, namely:

  • Add a test for the case when the renaming package's path contains "internal" as a segment.
  • Don't rename subpackages that don't belong to the same module with the renaming package (e.g. if we're renaming lib->lib1 and lib/submod is a sub module, then we should not rename packages in lib/submod -- this may actually work already but needs verification)
  • Check the go.mod files in the workspace to see if any replace directives need to be fixed if the renaming affects the locations of any go.mod files (e.g. in the previous step, any replace directives pointing at lib/submod need to be updated).

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions