The export data encoding was not symmetric in the case where objectpath
fails.

Fixes golang/go#61670

Change-Id: Ifaaa8eaed7ee5e28aa3b5ee7e9600b9e379e1968
Reviewed-on: https://go-review.googlesource.com/c/tools/+/514355
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Robert Findley <rfindley@google.com>

Fix the stubmethods code action when matching against calls of variadic
functions, and add a regression test.

Additionally, reinstate panic recovery for code actions that were
migrated from convenience analyzers. I do not have confidence that this
is the only such panic.

Fixes golang/go#61693

Change-Id: Id2642a13d3f793de27c0d7ebfa665428d671c56f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/514755
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>

Fixes golang/go#61692

Change-Id: I97bd85c063ac1f525fd01c2b1a8b5ffe574e1c66
Reviewed-on: https://go-review.googlesource.com/c/tools/+/514815
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>

Generalize the 'seenTParams' map to short-circuit all forms of infinite
recursion in the lockPath function, not just through type parameters.

For invalid code, it is possible to have infinite recursion through
named types.

Fixes golang/go#61678

Change-Id: I59d39c6fcaf3dd8bbd4f989516e2fb373b277889
Reviewed-on: https://go-review.googlesource.com/c/tools/+/514818
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

These counters are incremented once per session
when the LSP initialize message is received.

This cl adds a new dependency on x/telemetry.

Note that writing to the disk will be enabled when
GOPLS_TELEMETRY_EXP is set. We plan to remove this
condition once we are ready.

Updates golang/go#61038

Change-Id: Ibb8ebbd039ab5ffbaa869dee01bee0ba5450f350
Reviewed-on: https://go-review.googlesource.com/c/tools/+/506635
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>

This counter (tentatively named 'gopls/bug') will track and report
the number of `report` calls.

Since bug.Report* can be called in a type loop, we increment
the stack counter only where this is the first exemplar, and
after getting out of the critical section.

Change-Id: I42ee385bd69bc148454a82c98f7d623d5c803907
Reviewed-on: https://go-review.googlesource.com/c/tools/+/513100
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>

As reported in golang/go#61674, there are certain cases involving
instantiated fields that simply can't be encoded using objectpaths.
Therefore, the workaround is fundamentally insufficient, and should
probably be removed or made irrelevant (golang/go#61674). In the
meantime, update commentary and remove the bug report.

Update the gopls regression test for this behavior to exercise the
objectpath failure. While at it, ensure that the marker regtests panic
on bugs, like all other regtests. This ran into an existing imprecise
bug report, which is amended.

Updates golang/go#61674

Change-Id: I0eaea00d46cec88ac4c20cebdde805a7db3a33ad
Reviewed-on: https://go-review.googlesource.com/c/tools/+/514575
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

Update golang.org/x dependencies to their latest tagged versions.
Once this CL is submitted, and post-submit testing succeeds on all
first-class ports across all supported Go versions, this repository
will be tagged with its next minor version.

Change-Id: I5624b9375a1de6bb7e6965b308186b8670b402bb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/516038
Auto-Submit: Gopher Robot <gobot@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

Neither of these two analysis passes relies on the now-deprecated
object tracking in go/ast populated by go/parser.

Change-Id: I8ec18d1552aedf437b2b663a2698010a6faee7c9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/516575
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>

This change enables the new defers analyzer in gopls.
It also adds it to the vet compatibility test.
A follow-up change will add it to vet itself.

Also, remove stray backquote in doc comment.

Updates golang/go#60048

Change-Id: I42f09bb79fcbe4e48593dd32fd066ddd39b9626f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/502975
Run-TryBot: Alan Donovan <adonovan@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>