language: fix TestBestMatchAlloc test #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dpaks wants to merge 1 commit into golang:master from dpaks:TestBestMatchAlloc_test_fix

dpaks commented May 22, 2021

The test calls testing.AllocsPerRun with a count of 1.
AllocsPerRun sets runtime.GOMAXPROCS to 1, but it doesn't prevent the runtime from descheduling a goroutine
and performing an allocation somewhere in the background.
This commit changes the test to use a number of runs large enough to average away the occasional noisy allocation.

Fixes golang/go#45809


          language: fix TestBestMatchAlloc test

1606b69

The test calls testing.AllocsPerRun with a count of 1.
AllocsPerRun sets runtime.GOMAXPROCS to 1, but it doesn't prevent the runtime from descheduling a goroutine
and performing an allocation somewhere in the background.
This commit changes the test to use a number of runs large enough to average away the occasional noisy allocation.

Fixes golang/go#45809

google-cla bot added the cla: yes label

Contributor

gopherbot commented May 22, 2021

This PR (HEAD: 1606b69) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/321737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented May 22, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2021

Message from Deepak S:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2021

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 24, 2021

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 24, 2021

Message from Michael Knyszek:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          language: use multiple runs in TestBestMatchAlloc

3115f89

AllocsPerRun sets runtime.GOMAXPROCS to 1, but it doesn't prevent the runtime from descheduling a goroutine
and performing an allocation somewhere in the background.
This commit changes the test to use a number of runs large enough to average away the occasional noisy allocation.

Fixes golang/go#45809

Change-Id: Ibf904016d0c067740469c8e861079611440222a1
GitHub-Last-Rev: 1606b69
GitHub-Pull-Request: #23
Reviewed-on: https://go-review.googlesource.com/c/text/+/321737
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Michael Knyszek <mknyszek@google.com>

Contributor

gopherbot commented May 24, 2021

Message from Bryan C. Mills:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/321737.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 24, 2021

This PR is being closed because golang.org/cl/321737 has been merged.

gopherbot closed this

Author

dpaks commented May 24, 2021

Thanks for merging! :)

xhit pushed a commit to xhit/text that referenced this pull request


          language: use multiple runs in TestBestMatchAlloc

b18f9df

AllocsPerRun sets runtime.GOMAXPROCS to 1, but it doesn't prevent the runtime from descheduling a goroutine
and performing an allocation somewhere in the background.
This commit changes the test to use a number of runs large enough to average away the occasional noisy allocation.

Fixes golang/go#45809

Change-Id: Ibf904016d0c067740469c8e861079611440222a1
GitHub-Last-Rev: 1606b69
GitHub-Pull-Request: golang#23
Reviewed-on: https://go-review.googlesource.com/c/text/+/321737
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Michael Knyszek <mknyszek@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels