Skip to content

number: match input example to be Dutch as in the output #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

number: match input example to be Dutch as in the output #21

wants to merge 1 commit into from

Conversation

carleeto
Copy link
Contributor

@carleeto carleeto commented Mar 1, 2021 •
edited
Loading

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 1, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 7026b4e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/297589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl .:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0e1c20eb

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl .:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1:

Thanks for the reply and for the questions:

  • Yes, to make updates you’ll just make them on your GitHub PR and force push to update

  • To update the commit message and title you need to manually edit the GitHub PR commit message and title, not the actual git commit

And you are almost there!

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@carleeto carleeto changed the title Fix incorrect dutch example in number/doc.go number: match input example to be Dutch as in the output Apr 11, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 0421867) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/297589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carl .:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl .:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 3: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=00774b30

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl .:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/297589.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 11, 2021
@carleeto @tklauser
number: match input example to be Dutch as in the output
c2d28a6 
Change-Id: I5d1eaf79aa267121ce08dc3990b86ff30c8e0505
GitHub-Last-Rev: 0421867
GitHub-Pull-Request: #21
Reviewed-on: https://go-review.googlesource.com/c/text/+/297589
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/297589 has been merged.

@gopherbot gopherbot closed this Apr 11, 2021
@carleeto carleeto deleted the patch-1 branch April 11, 2021 21:01
xhit pushed a commit to xhit/text that referenced this pull request Oct 10, 2022
@carleeto @xhit
number: match input example to be Dutch as in the output
9aafe27 
Change-Id: I5d1eaf79aa267121ce08dc3990b86ff30c8e0505
GitHub-Last-Rev: 0421867
GitHub-Pull-Request: golang#21
Reviewed-on: https://go-review.googlesource.com/c/text/+/297589
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carleeto @gopherbot