Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.0
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.24.0
Choose a head ref
  • 18 commits
  • 41 files changed
  • 9 contributors

Commits on Sep 4, 2024

  1. all: fix printf(var) mistakes detected by latest printf checker

    The CodeWriter.WriteComment method is odd. It calls fmt.Sprintf
    on its arguments so the caller doesn't need to, but isn't named
    something like WriteCommentf as I'd expect. I tried renaming it,
    but it became a bigger change than I wanted. Leaving that for a
    future CL - this one just fixes clear mistakes to fix the build.
    
    For golang/go#69267.
    
    Change-Id: Ifba42d4512696194fbf21d6c8d3da76440b1ce9e
    Reviewed-on: https://go-review.googlesource.com/c/text/+/610676
    Reviewed-by: Tim King <taking@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    dmitshur authored and gopherbot committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    20097e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. all: fix some comments

    Change-Id: I6ba7a9de50acfa522d96609abead28d207ab4f81
    Reviewed-on: https://go-review.googlesource.com/c/text/+/611795
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Tim King <taking@google.com>
    Auto-Submit: Tim King <taking@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    cuishuang authored and gopherbot committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    38a95c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. x/text: Correct examples in number/doc

    Playground example: https://go.dev/play/p/9cuRyaNveO8
    
    Change-Id: I2fbc3fec0f3755eb3d11b47edfb2201d66fc622d
    Reviewed-on: https://go-review.googlesource.com/c/text/+/614395
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    dveeden authored and gopherbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3043346 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. all: normalize subtest names to NFC

    LUCI builders upload test results to ResultDB, which permits printable
    Unicode characters in test names, provided they're written in NFC form.
    
    Change-Id: I0abf67beb52da722af97e6981c308c4b4d801cbb
    Reviewed-on: https://go-review.googlesource.com/c/text/+/621555
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    dmitshur authored and gopherbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a457f47 View commit details
    Browse the repository at this point in the history
  2. internal/texttest: remove Run and Bench helpers

    Versions of Go whose testing package doesn't yet support subtests and
    sub-benchmarks are no longer supported. Drop an intermediate layer of
    compatibility from the ./internal/texttest package.
    
    The initial version of this change was git-generate'd with the script:
    
    rm internal/testtext/go1_{6,7}.go
    gofmt -r 'testtext.Run(t, n, f) -> t.Run(n, f)' -w .
    gofmt -r 'testtext.Bench(b, n, f) -> b.Run(n, f)' -w .
    goimports -w .
    
    Unfortunately it seems gofmt -r dropped inner comments inside f, and
    also added some spurious blank lines. So it was manually amended not
    to include those changes.
    
    Change-Id: I5bcb553b90ce392aada7896d576194be479f2616
    Reviewed-on: https://go-review.googlesource.com/c/text/+/621575
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    dmitshur authored and gopherbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fefda1a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. README: don't recommend go get

    These days people will just import the packages and the go tool will
    do the right thing. We don't need to explain it.
    
    Add a pointer to the git repo, though.
    
    For golang/go#62645
    
    Change-Id: I0a1721eb456645c1422580497e3dcc9906a41223
    Reviewed-on: https://go-review.googlesource.com/c/text/+/624296
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    ianlancetaylor authored and gopherbot committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8a0e65e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I6b939f9a4f016b265d30fbd408f34705f89c0982
    Reviewed-on: https://go-review.googlesource.com/c/text/+/626375
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    gopherbot committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    efd25da View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I02eb549b47bf711f9c70b10ef33f619c19129bee
    Reviewed-on: https://go-review.googlesource.com/c/text/+/633477
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    gopherbot committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    d42948e View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. message/pipeline: add two Unalias calls

    Change-Id: I692c027e2b97ee5509a63a2c88265759fc766800
    Reviewed-on: https://go-review.googlesource.com/c/text/+/645016
    Auto-Submit: Alan Donovan <adonovan@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    adonovan authored and gopherbot committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    1e59086 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2025

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: If969fddb3ff610170fae2ad6b797be516e98b0f4
    Reviewed-on: https://go-review.googlesource.com/c/text/+/646475
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Feb 4, 2025
    Configuration menu
    Copy the full SHA
    3b64043 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. all: upgrade go directive to at least 1.23.0 [generated]

    By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
    per the Go Release Policy (https://go.dev/doc/devel/release#policy).
    
    For golang/go#69095.
    
    [git-generate]
    (cd . && go get go@1.23.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none)
    
    Change-Id: I315d8641c8a1501284ec7295493d23523afbcc0f
    Reviewed-on: https://go-review.googlesource.com/c/text/+/649698
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    gopherbot committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    518d9c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2025

  1. internal/export/unicode: add CategoryAliases, Cn, and LC

    CategoryAliases is for regexp to use, for things like \p{Letter} as an alias for \p{L}.
    Cn and LC are special-case categories that were never implemented
    but should have been.
    
    For golang/go#70780.
    
    Change-Id: I1401c1be42106a0ebecabb085c25e97485c363cf
    Reviewed-on: https://go-review.googlesource.com/c/text/+/641395
    Auto-Submit: Russ Cox <rsc@golang.org>
    Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    rsc authored and gopherbot committed Feb 27, 2025
    Configuration menu
    Copy the full SHA
    ae68efb View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2025

  1. language: use a more straightforward return value

    Change-Id: I7f5d8ecc1ad6a1ff110283d2c62816170922e72c
    Reviewed-on: https://go-review.googlesource.com/c/text/+/653236
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    cuishuang authored and gopherbot committed Feb 28, 2025
    Configuration menu
    Copy the full SHA
    835f8ac View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2025

  1. internal/export/unicode: change C comment to mention unassigned code …

    …points
    
    As of CL 641395, C includes unassigned code points.
    (It always has in the Unicode definition.)
    Document that.
    
    Change-Id: Icab0ef37e6efeebb1e2882f7743e29acc7ab77d8
    Reviewed-on: https://go-review.googlesource.com/c/text/+/653615
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Sean Liao <sean@liao.dev>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    rsc authored and gopherbot committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    b18c107 View commit details
    Browse the repository at this point in the history
  2. x/text: fix scientific notation by removing extraneous spaces

    The existing implementation adds extraneous spaces around the
    superscriptingExponent. This is different from what ICU4C does.
    It also turns out adding those extra spaces messes with other
    padding calculations.
    
    Fixes golang/go#71428
    
    Change-Id: Id6702390dc40c17bdd5dff2597aa8e1044f5768e
    Reviewed-on: https://go-review.googlesource.com/c/text/+/644121
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Tristan Swadell <tswadell@google.com>
    jcking authored and gopherbot committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    221d88c View commit details
    Browse the repository at this point in the history
  3. collate/build: do not use println in tests

    Change-Id: I4f50430a35b009618c4762c74c418919dc54cdb1
    Reviewed-on: https://go-review.googlesource.com/c/text/+/634495
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    alexandear authored and gopherbot committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    d5156da View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2025

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ie292e82f774d7a7b2ab5d53279bd874dae6cbdac
    Reviewed-on: https://go-review.googlesource.com/c/text/+/655036
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Mar 5, 2025
    Configuration menu
    Copy the full SHA
    566b44f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2025

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I1a68d897a5fe8375d604a0163ea501c964c79f4f
    Reviewed-on: https://go-review.googlesource.com/c/text/+/663096
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Apr 6, 2025
    Configuration menu
    Copy the full SHA
    4890c57 View commit details
    Browse the repository at this point in the history
Loading