Skip to content

Conversation

natefinch
Copy link

This adds support needed for golangci/golangci-lint#2261

Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @SVilgelm to do as early return as possible, other than that LGTM!

@natefinch
Copy link
Author

Yeah, I wasn't super clear on what the whole fpos hunkpos stuff was doing, so I figured it was safer to put this at the end where we know we don't have another right answer. But if you think this is still the right answer at line 118, I'm happy to move it.

@SVilgelm SVilgelm merged commit c22e500 into golangci:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants