Skip to content

Conversation

nachtjasmin
Copy link
Contributor

@nachtjasmin nachtjasmin commented Mar 3, 2025

Since there's some kind of official documentation for this, I decided to link it.

edit: we could even link to the official "CI/CD component" if wanted.

Copy link

boring-cyborg bot commented Mar 3, 2025

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title docs(integrations): add GitLab documentation docs: add GitLab documentation Mar 3, 2025
@ldez ldez added the area: docs label Mar 3, 2025
@ldez ldez self-requested a review March 3, 2025 12:12
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I think the content of "CI Integration" should be replaced by a link to https://golangci-lint.run/welcome/install/#ci-installation

And your modifications should be moved to this section.

@ldez ldez added the feedback required Requires additional feedback label Mar 3, 2025
@ldez ldez added enhancement New feature or improvement and removed feedback required Requires additional feedback labels Mar 3, 2025
@ldez ldez added this to the unreleased milestone Mar 3, 2025
@nachtjasmin
Copy link
Contributor Author

Just added one additional note about the domain of CI components, just so that self-hosted users do not have to search for that in the GitLab documentation first.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit d0ec328 into golangci:master Mar 3, 2025
18 checks passed
@ldez ldez modified the milestones: unreleased, v1.64 Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants