Skip to content

GitHub Annotations suppresses normal output #362

@directionless

Description

@directionless

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

I really love that the github action supports annotations. But when using it, there is minimal other output. Specifically, while the message is printed, it lacks the file/line number. (And at least sometimes, Github itself doesn't display anything at all)

Everything is in the annotations, but those don't display properly in a couple of cases:

  1. Newly added linters may find things outside the PR. Those annotations are not displayed anywhere. (There's a note that they happened, but no link to a file and line number
  2. If there are a lot of failures, having a clear list would be helpful

I'm not sure if this is a bug or a feature request...

I'd suggest either a normal print along side the github actions print, or allowing multiple out-formats to be specified.

Version of golangci-lint

github actions
      - uses: actions/checkout@v2
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v2
        with:
          version: v1.42

Configuration file

N/A

Go environment

GitHub Actions

Verbose output of running

No Output:


No Output

Minimal Output:


Minimal Output

None of those include file/line number

Code example or link to a public repository

https://github.com/kolide/launcher/runs/4039960409?check_suite_focus=true

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions