Skip to content

Conversation

barrust
Copy link
Collaborator

@barrust barrust commented Oct 5, 2022

resolves #151

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #152 (6c61fad) into master (7009da7) will decrease coverage by 0.04%.
The diff coverage is 92.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   91.08%   91.03%   -0.05%     
==========================================
  Files          30       30              
  Lines        2287     2409     +122     
==========================================
+ Hits         2083     2193     +110     
- Misses        204      216      +12     
Impacted Files Coverage Δ
goose3/utils/encoding.py 51.92% <ø> (+13.46%) ⬆️
goose3/parsers.py 89.24% <85.15%> (-4.68%) ⬇️
goose3/outputformatters.py 94.59% <92.30%> (ø)
goose3/extractors/images.py 92.46% <93.33%> (ø)
goose3/cleaners.py 98.08% <96.29%> (ø)
goose3/extractors/authors.py 100.00% <100.00%> (ø)
goose3/extractors/content.py 99.14% <100.00%> (ø)
goose3/extractors/links.py 100.00% <100.00%> (ø)
goose3/extractors/metas.py 98.43% <100.00%> (ø)
goose3/extractors/opengraph.py 100.00% <100.00%> (ø)
... and 10 more

Copy link
Contributor

@lababidi lababidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you alias the snake case name to a camel case name to prevent breaking?

@barrust
Copy link
Collaborator Author

barrust commented Oct 6, 2022

@lababidi Yes, we can do that as it should be simple. I can push that later today. But, to be honest, it really shouldn't matter as someone shouldn't really be using the Parser and Text classes from goose3. If we do put aliases in, then I think we should put together a plan for deprecating them out.

@lababidi
Copy link
Contributor

lababidi commented Oct 7, 2022

100% agreed. You can put the deprecated decorator

@barrust
Copy link
Collaborator Author

barrust commented Oct 7, 2022

Added a deprecated decorator and a fail_after decorator to have tests fail if they are not removed prior to a specific version. I set that to be 3.1.14 but that can be changed easily enough.

What I did find is that a lot of the parser code is not directly tested. I put stub tests in for them but wanted that to be tracked.

@barrust barrust requested a review from lababidi October 7, 2022 15:33
Copy link
Contributor

@lababidi lababidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

@barrust
Copy link
Collaborator Author

barrust commented Oct 8, 2022

Thanks! I built the two decorators in another project and it was fairly straight forward to make them work here!

@barrust barrust merged commit e39ca61 into master Oct 8, 2022
@barrust barrust deleted the snake_case branch October 8, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camelCase -> snake_case
3 participants