-
Notifications
You must be signed in to change notification settings - Fork 108
camelCase -> snake_case #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 91.08% 91.03% -0.05%
==========================================
Files 30 30
Lines 2287 2409 +122
==========================================
+ Hits 2083 2193 +110
- Misses 204 216 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you alias the snake case name to a camel case name to prevent breaking?
@lababidi Yes, we can do that as it should be simple. I can push that later today. But, to be honest, it really shouldn't matter as someone shouldn't really be using the Parser and Text classes from goose3. If we do put aliases in, then I think we should put together a plan for deprecating them out. |
100% agreed. You can put the deprecated decorator |
Added a What I did find is that a lot of the parser code is not directly tested. I put stub tests in for them but wanted that to be tracked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic!
Thanks! I built the two decorators in another project and it was fairly straight forward to make them work here! |
resolves #151