Skip to content

Conversation

barrust
Copy link
Collaborator

@barrust barrust commented Aug 30, 2022

resolves #141

@lababidi what do you think?

@codecov-commenter
Copy link

Codecov Report

Merging #142 (14010b5) into master (4f9160f) will decrease coverage by 0.22%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   91.05%   90.83%   -0.23%     
==========================================
  Files          30       30              
  Lines        2326     2335       +9     
==========================================
+ Hits         2118     2121       +3     
- Misses        208      214       +6     
Impacted Files Coverage Δ
goose3/text.py 88.05% <45.45%> (-3.95%) ⬇️

Copy link
Contributor

@lababidi lababidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. lgtm

@barrust barrust merged commit 3b19f33 into master Sep 2, 2022
@barrust barrust deleted the issue-141 branch September 2, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unwanted dependency (jieba)
3 participants