Skip to content

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #4193

Special notes for your reviewer:

@0xaravindh 0xaravindh self-assigned this Jun 4, 2025
@0xaravindh 0xaravindh requested a review from igooch June 4, 2025 10:47
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 4, 2025
@0xaravindh 0xaravindh requested a review from gongmax June 4, 2025 10:47
Copy link

github-actions bot commented Jun 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.


# overwrite kubectl as we want a specific version
RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v${KUBERNETES_VER}/bin/linux/amd64/kubectl && \
RUN curl -LO https://dl.k8s.io/release/v${KUBERNETES_VER}/bin/linux/amd64/kubectl && \
Copy link
Member Author

@0xaravindh 0xaravindh Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igooch Switched to dl.k8s.io for kubectl download — it's the official and supported source now.
kubernetes/k8s.io#2396

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ee99f772-227a-47c6-add8-299b809020ff

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f9fc59a6-7bf6-4bcc-9655-78eebdf31460

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: e7736c08-a722-481b-bba8-fe34da9e680d

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Jun 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1ab5d3ca-9d64-41fb-8458-b5203d6a3d2e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4199/head:pr_4199 && git checkout pr_4199
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-c1da2c4

Copy link
Collaborator

@vicentefb vicentefb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igooch igooch merged commit fd70269 into googleforgames:main Jun 6, 2025
4 checks passed
@0xaravindh 0xaravindh added the kind/breaking Breaking change label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants