fix: exclude InactiveScheduleError for error logging #4183

indexjoseph · 2025-05-14T18:13:42Z

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Exclude InactiveScheduleError for error logging as it's expected behavior when iterating through the chain.
This will prevent unnecessary noise as we are already logging events for policies that are being applied and don't want to log Schedule policies that are not being applied due to InactiveScheduleError.

Which issue(s) this PR fixes:
This is a follow-up to #4179

Special notes for your reviewer:

Exclude InactiveScheduleError for error logging as it's expected behavior within the chain

peterzhongyi · 2025-05-14T18:18:11Z

/gcbrun

agones-bot · 2025-05-14T18:31:32Z

Build Failed 😭

Build Id: 27225b80-24de-4379-80c4-c46cc4c22501

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2025-05-14T23:37:35Z

/gcbrun

agones-bot · 2025-05-14T23:47:47Z

Build Failed 😭

Build Id: 51c58989-1d9b-4fc0-95d5-6399cd16097a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

indexjoseph · 2025-05-14T23:56:16Z

Looks like there's something wrong with the make build-images step, it started w/ the last merged PR but I don't think it's related to the changes made.

igooch · 2025-05-15T00:00:11Z

make: *** [Makefile:624: build-agones-sdk-image-windows-ltsc2019] Error 1
ERROR: failed to solve: failed to compute cache key: failed to copy: httpReadSeeker: failed open: unexpected status code https://mcr.microsoft.com/v2/windows/servercore/blobs/sha256:d8565a0d56182c8ac77f73952365af8f01baa954279c01ee1a17bd648a428f87: 503 Service Unavailable

Not sure if this is an "us" problem a "them" problem or both :) @0xaravindh do you have the time to investigate?

0xaravindh · 2025-05-15T04:16:30Z

make: *** [Makefile:624: build-agones-sdk-image-windows-ltsc2019] Error 1
ERROR: failed to solve: failed to compute cache key: failed to copy: httpReadSeeker: failed open: unexpected status code https://mcr.microsoft.com/v2/windows/servercore/blobs/sha256:d8565a0d56182c8ac77f73952365af8f01baa954279c01ee1a17bd648a428f87: 503 Service Unavailable

Not sure if this is an "us" problem a "them" problem or both :) @0xaravindh do you have the time to investigate?

Thanks for pointing it out — I’ll take a look.

0xaravindh · 2025-05-15T05:28:37Z

/gcbrun

0xaravindh · 2025-05-15T05:39:13Z

/gcbrun

agones-bot · 2025-05-15T06:08:08Z

Build Failed 😭

Build Id: 63dae0c6-7bac-48a5-a925-65c47df1dc03

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-05-15T06:38:22Z

e2e Error

VERBOSE:     examples_test.go:83: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:83
VERBOSE:         	Error:      	Received unexpected error:
VERBOSE:         	            	waiting for {supertuxkart [{default  Dynamic <nil> 8080 0 UDP}] {false 60 0 30}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{supertuxkart us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.17 [] []  [] [] [{ENABLE_PLAYER_TRACKING false nil}] {map[] map[] []} [] <nil> [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] []}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1747289265/supertuxkart-xtvcj to be Ready: GameServer reached terminal state Unhealthy
VERBOSE:         	Test:       	TestSuperTuxKartGameServerReady
VERBOSE: --- FAIL: TestSuperTuxKartGameServerReady (13.34s)
VERBOSE: FAIL

0xaravindh · 2025-05-15T06:40:49Z

make: *** [Makefile:624: build-agones-sdk-image-windows-ltsc2019] Error 1
ERROR: failed to solve: failed to compute cache key: failed to copy: httpReadSeeker: failed open: unexpected status code https://mcr.microsoft.com/v2/windows/servercore/blobs/sha256:d8565a0d56182c8ac77f73952365af8f01baa954279c01ee1a17bd648a428f87: 503 Service Unavailable

Not sure if this is an "us" problem a "them" problem or both :) @0xaravindh do you have the time to investigate?

I didn’t face this error on my side. It might be a temporary issue from Microsoft’s end.

0xaravindh · 2025-05-15T06:41:17Z

/gcbrun

agones-bot · 2025-05-15T07:30:41Z

Build Failed 😭

Build Id: 452b2616-5642-4fc9-8d0d-968ad747b58f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-05-15T08:39:04Z

/gcbrun

agones-bot · 2025-05-15T09:32:51Z

Build Succeeded 🥳

Build Id: b5a95ea6-a502-45db-84ce-2fcedbbae69f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-c17010f
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-c17010f
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-c17010f-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-c17010f
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-c17010f
Linux C++ SDK (build): agonessdk-1.50.0-dev-c17010f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-c17010f.zip

A preview of the website (the last 30 builds are retained):

https://c17010f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4183/head:pr_4183 && git checkout pr_4183
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-c17010f

0xaravindh · 2025-05-16T04:01:37Z

/gcbrun

agones-bot · 2025-05-16T05:01:39Z

Build Succeeded 🥳

Build Id: 84fca4c9-7ab2-4143-b932-1ae036ae545f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-307ef60
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-307ef60
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-307ef60-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-307ef60
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-307ef60
Linux C++ SDK (build): agonessdk-1.50.0-dev-307ef60-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-307ef60.zip

A preview of the website (the last 30 builds are retained):

https://307ef60-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4183/head:pr_4183 && git checkout pr_4183
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-307ef60

indexjoseph · 2025-05-16T19:16:37Z

@peterzhongyi I think this is ready for review/submission

0xaravindh · 2025-05-19T04:59:52Z

/gcbrun

agones-bot · 2025-05-19T05:58:35Z

Build Succeeded 🥳

Build Id: cc8c9012-8b95-4df1-9346-901224849bfb

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-e6b4c50
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-e6b4c50
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-e6b4c50-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-e6b4c50
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-e6b4c50
Linux C++ SDK (build): agonessdk-1.50.0-dev-e6b4c50-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-e6b4c50.zip

A preview of the website (the last 30 builds are retained):

https://e6b4c50-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4183/head:pr_4183 && git checkout pr_4183
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-e6b4c50

0xaravindh · 2025-05-29T04:39:07Z

/gcbrun

agones-bot · 2025-05-29T04:53:37Z

Build Failed 😭

Build Id: f1dbe4fd-2e09-4a7b-a82f-3ab6a63bc23b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-05-29T05:42:30Z

/gcbrun

agones-bot · 2025-05-29T05:52:10Z

Build Failed 😭

Build Id: 30d2d0ae-f330-43d0-8b0b-297e014cb3bf

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2025-05-29T23:46:26Z

/gcbrun

agones-bot · 2025-05-30T00:46:15Z

Build Succeeded 🥳

Build Id: 4e2de8cb-d01d-4c0b-8e0d-b267efcaf3ae

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-2e28032
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-2e28032
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-2e28032-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-2e28032
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-2e28032
Linux C++ SDK (build): agonessdk-1.50.0-dev-2e28032-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-2e28032.zip

A preview of the website (the last 30 builds are retained):

https://2e28032-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4183/head:pr_4183 && git checkout pr_4183
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-2e28032

peterzhongyi

LGTM

Exclude InactiveScheduleError for error logging

27c2316

Exclude InactiveScheduleError for error logging as it's expected behavior within the chain

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label May 14, 2025

correct comment for controller error logging

2fd99eb

indexjoseph changed the title ~~Exclude InactiveScheduleError for error logging~~ fix: exclude InactiveScheduleError for error logging May 14, 2025

fix typo in controller error checking comment

c17010f

Merge branch 'main' into indexjoseph-patch-1-1

307ef60

Merge branch 'main' into indexjoseph-patch-1-1

e6b4c50

0xaravindh requested review from igooch and peterzhongyi May 19, 2025 06:01

Merge branch 'main' into indexjoseph-patch-1-1

2e28032

github-actions bot added the size/XS label May 28, 2025

peterzhongyi approved these changes May 30, 2025

View reviewed changes

peterzhongyi merged commit 95112c1 into googleforgames:main May 30, 2025
4 checks passed

fix: exclude InactiveScheduleError for error logging #4183

fix: exclude InactiveScheduleError for error logging #4183

Uh oh!

Conversation

indexjoseph commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterzhongyi commented May 14, 2025

Uh oh!

agones-bot commented May 14, 2025

Uh oh!

igooch commented May 14, 2025

Uh oh!

agones-bot commented May 14, 2025

Uh oh!

indexjoseph commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

igooch commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

agones-bot commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

agones-bot commented May 15, 2025

Uh oh!

0xaravindh commented May 15, 2025

Uh oh!

agones-bot commented May 15, 2025

Uh oh!

0xaravindh commented May 16, 2025

Uh oh!

agones-bot commented May 16, 2025

Uh oh!

indexjoseph commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xaravindh commented May 19, 2025

Uh oh!

agones-bot commented May 19, 2025

Uh oh!

0xaravindh commented May 29, 2025

Uh oh!

agones-bot commented May 29, 2025

Uh oh!

0xaravindh commented May 29, 2025

Uh oh!

agones-bot commented May 29, 2025

Uh oh!

igooch commented May 29, 2025

Uh oh!

agones-bot commented May 30, 2025

Uh oh!

peterzhongyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

indexjoseph commented May 14, 2025 •

edited

Loading

indexjoseph commented May 14, 2025 •

edited

Loading

indexjoseph commented May 16, 2025 •

edited

Loading