Skip to content

Enhance logging and error handling in computeDesiredFleetSize, including Chain policies #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Enhance logging and error handling in computeDesiredFleetSize, including Chain policies #4179

merged 3 commits into from
May 14, 2025

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3955

Special notes for your reviewer:

@0xaravindh 0xaravindh self-assigned this May 13, 2025
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label May 13, 2025
@0xaravindh 0xaravindh requested review from vicentefb and igooch May 13, 2025 07:16
@0xaravindh
Copy link
Member Author

@indexjoseph Could you please review the changes in this PR?

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 98b430b8-1311-449a-8690-15a1faf27cfb

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 33d7e0f5-7473-4157-b883-9d001620c588

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 3068d44a-c977-4be9-ba81-21ac77a60f31

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7127759c-c9dc-4caf-8561-12a93239f9e1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4179/head:pr_4179 && git checkout pr_4179
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-ecac01f

@indexjoseph
Copy link
Contributor

@0xaravindh Other than the error-checking case for the SchedulePolicyType, this LGTM.

peterzhongyi
peterzhongyi approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@peterzhongyi peterzhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving LGTM on behalf of Joseph.

@peterzhongyi peterzhongyi merged commit e256084 into googleforgames:main May 14, 2025
4 checks passed
This was referenced May 14, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhongyi peterzhongyi peterzhongyi approved these changes

@vicentefb vicentefb Awaiting requested review from vicentefb

@igooch igooch Awaiting requested review from igooch

Assignees

@0xaravindh 0xaravindh

Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging to policies that return errors within Chain policies
5 participants
@0xaravindh @agones-bot @indexjoseph @peterzhongyi @igooch