Skip to content

Feat: allow push-chart to custom helm registry #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

Feat: allow push-chart to custom helm registry #4172

merged 3 commits into from
May 18, 2025

Conversation

lacroixthomas
Copy link
Collaborator

@lacroixthomas lacroixthomas commented May 2, 2025 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / Why we need it:
This PR is to support pushing current chart to a private registry using CHARTS_REGISTRY

It would help testing within my infra, the REGISTRY was already supported to push my builds but the charts were "linked" to the GCP_BUCKET_CHARTS

I could run REGISTRY=... CHART_REGISTRY=... make build-images && make push && make push-chart

Which issue(s) this PR fixes:

Closes #4166

Special notes for your reviewer:

This is currently in WIP, I still need to do more tests around it and also updating the documentation

This would not update the index though, In my opinion it's fine as this is not to replace the main registry but for testing purpose within an infra

@github-actions github-actions bot added the kind/feature New features for Agones label May 2, 2025
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7059a6fd-a6b2-4630-b223-8be7b60ecfa6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4172/head:pr_4172 && git checkout pr_4172
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-ae417f1

markmandel
markmandel reviewed May 4, 2025
View reviewed changes
build/includes/release.mk Outdated
push-chart: $(ensure-build-image) build-chart
ifdef CHART_REGISTRY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only feedback would be that rather than an ifdef have CHART_REGISTRY set in Makefile with a default value (probably ""), and some description on it. At least then it's with all the other Makefile variables.

Also, it's not _super- up to date, but it would be good if this was documented here: https://github.com/googleforgames/agones/tree/main/build#make-variable-reference

But otherwise, good addition!

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 656c97e5-a680-4e13-a24f-d2367ed84d1f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4172/head:pr_4172 && git checkout pr_4172
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-cc2737f

markmandel
markmandel approved these changes May 4, 2025
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in draft 😄 you happy to have this merged? If so, I'm happy to approve.

@lacroixthomas
Copy link
Collaborator Author

lacroixthomas commented May 4, 2025 •
edited
Loading

Still in draft 😄 you happy to have this merged? If so, I'm happy to approve.

I'll keep it on draft until tomorrow, wanna double check with my pipeline if everything's fine or if I missed something first, ill get it out of draft tomorrow though 😄

@lacroixthomas lacroixthomas marked this pull request as ready for review May 5, 2025 12:45
@lacroixthomas
Copy link
Collaborator Author

I just double checked, it's good to go, moving out of draft 😄

@markmandel markmandel enabled auto-merge (squash) May 18, 2025 18:19
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ff8dcb7f-27b5-40af-9940-9bb7fa7d6cce

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4172/head:pr_4172 && git checkout pr_4172
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-104e93e

@markmandel markmandel merged commit abe22d4 into googleforgames:main May 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Proposal] - Support pushing charts to custom helm registry
3 participants
@lacroixthomas @agones-bot @markmandel