Fix feature stages page to show expected content #4156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😭 Build Id: d8d3095c-9c3b-42f9-a616-69d00bb8cfa3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
@igooch Do we need to update PortRanges (#4147) & PortPolicyNone (#4144) in the versionMap.yaml Dev session? agones/test/upgrade/versionMap.yaml Lines 96 to 98 in d07dabd |
|
Yes, please do. And if it's not in the instruction for alpha -> beta and
beta -> stable we should include that as well. `DisableResyncOnSDKServer`
should be removed as well since that went to stable.
…On Tue, Apr 15, 2025 at 8:08 AM Aravindh K ***@***.***> wrote:
@igooch <https://github.com/igooch> Do we need to update PortRanges (#4147
<#4147>) & PortPolicyNone (
#4144 <#4144>) in the
versionMap.yaml Dev session?
https://github.com/googleforgames/agones/blob/d07dabd7100c2a14717ec902080b59a2fdc399fe/test/upgrade/versionMap.yaml#L96-L98
—
Reply to this email directly, view it on GitHub
<#4156 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADINVQPTQE3HATENCF2V2232ZUOHZAVCNFSM6AAAAAB3FTQGISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBVHE3DONRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*0xaravindh* left a comment (googleforgames/agones#4156)
<#4156 (comment)>
@igooch <https://github.com/igooch> Do we need to update PortRanges (#4147
<#4147>) & PortPolicyNone (
#4144 <#4144>) in the
versionMap.yaml Dev session?
https://github.com/googleforgames/agones/blob/d07dabd7100c2a14717ec902080b59a2fdc399fe/test/upgrade/versionMap.yaml#L96-L98
—
Reply to this email directly, view it on GitHub
<#4156 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADINVQPTQE3HATENCF2V2232ZUOHZAVCNFSM6AAAAAB3FTQGISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBVHE3DONRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Build Succeeded 🥳 Build Id: 49b2d812-5ff8-4010-bf38-4c0a7f4b2cd9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: f6a00694-af1d-495d-92b8-62463e0c6a9e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 2b2a1c94-e854-46ec-824c-e0a117d36b54 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #4154
Special notes for your reviewer: