Skip to content

Adds instructions to update dependencies as part of upgrading Golang #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

Adds instructions to update dependencies as part of upgrading Golang #4155

merged 4 commits into from
Apr 25, 2025

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Apr 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

  • Adds a GitHub workflow to create an "Golang MAJOR.MINOR.PATCH Version and Dependency Upgrades" issue every six weeks (two weeks before the Agones release).
  • Adds instructions for updating Golang dependencies using go get -u as part of the issue template.
  • This ensures that Golang and dependencies are updated regularly, and includes all recent security updates.
  • This allows for 2 weeks of soak time before an Agones release.
  • This reduces the amount of toil in updating every time dependabot makes a PR, specifically the toil updating example images and image tags.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 14, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 63409034-3d03-4fde-a140-4ae544e29171

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the dependency-updates branch from fcb39b8 to 3ab7495 Compare April 15, 2025 19:46
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 95f6560e-6790-4d89-95e3-6e8aee248243

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the dependency-updates branch 2 times, most recently from dc26fcc to 5aab876 Compare April 15, 2025 20:41
igooch added 2 commits April 15, 2025 13:43
@igooch
Adds instructions to update dependencies as part of upgrading Golang
005bf24 
Creates a new GitHub workflow to create an issue every six weeks to upgrade Golang and dependencies.
@igooch
Update to JasonEtco/create-an-issue@v2 as gh cli cannot create from t…
05f79d8 
…emplate in a non-interactive session
@igooch igooch force-pushed the dependency-updates branch from 5aab876 to 05f79d8 Compare April 15, 2025 20:43
@igooch
Copy link
Collaborator Author

igooch commented Apr 15, 2025

During testing I was able to create issues on my own fork of the repo. However, I was not able to create an issue in the Agones repo. It's unclear if it was unable to create because of permissions issues due to this being a pull request from a fork, or some other permissions issue that will persist after merge.

Screenshot 2025-04-15 at 1 43 56 PM

@igooch igooch marked this pull request as ready for review April 15, 2025 20:47
@igooch igooch requested a review from peterzhongyi April 15, 2025 20:47
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 13aba6d4-f0fb-4cba-8fd1-3a292164b62e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4155/head:pr_4155 && git checkout pr_4155
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-05f79d8

peterzhongyi
peterzhongyi approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@peterzhongyi peterzhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterzhongyi peterzhongyi enabled auto-merge (squash) April 24, 2025 20:22
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a10fef0d-4d61-47ae-98f8-ef6dc6c3ab7f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 35e573fa-8fbd-4ebf-92d4-fa49cd3d89e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4155/head:pr_4155 && git checkout pr_4155
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-23ca6be

@peterzhongyi peterzhongyi merged commit 97b07cc into googleforgames:main Apr 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhongyi peterzhongyi peterzhongyi approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @peterzhongyi