Skip to content

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Mar 31, 2025

What type of PR is this?

/kind feature

What this PR does / Why we need it:

FeatureDisableResyncOnSDKServer has been in Beta, and on by default, for 11 months with no issues filed. This PR is to promote the feature to Stable, which means that the feature now cannot be turned off.

We maintain the feature flag name, so that on upgrade a new controller does not fail to parse the feature flag name.

Which issue(s) this PR fixes:

Closes # 4137

Special notes for your reviewer:

This PR does not warn that setting a stable feature flag to false is a no-op.
This PR does not include instructions for upgrading a SDK feature from Beta -> GA.

Those should be handled as separate issues / PRs.

@igooch igooch requested review from markmandel and gongmax March 31, 2025 18:40
@github-actions github-actions bot added the kind/feature New features for Agones label Mar 31, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ded58c8c-df23-4532-8d7d-5fcebe29dca9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: dc93314f-bd3d-4962-8b96-8085ac7a2b76

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

So TestAllocatorWithDeprecatedRequired has been consistently flaky for me too, and it was driving me up the wall. I'm glad (?) to see it wasn't just me 😁

@igooch
Copy link
Collaborator Author

igooch commented Mar 31, 2025

Looks like it's tired of being ignored 😁

@markmandel
Copy link
Collaborator

markmandel commented Mar 31, 2025

I've noticed it seems to be particularly that whole suite -- the Fleet just won't spin up. It also seems to only be on Autopilot.

Not sure if the clusters have hit quota maybe?

@igooch
Copy link
Collaborator Author

igooch commented Apr 1, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a434857a-98fb-4d1a-8768-b63b7327758e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4138/head:pr_4138 && git checkout pr_4138
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-2e29bff

@igooch igooch force-pushed the FeatureDisableResyncOnSDKServerStable branch from 2e29bff to 7f2404f Compare April 7, 2025 20:01
@igooch igooch force-pushed the FeatureDisableResyncOnSDKServerStable branch from 7f2404f to 910a458 Compare April 7, 2025 20:02
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6c2c4863-4f2f-49d1-a5a1-1b48a9889db2

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax
Copy link
Collaborator

gongmax commented Apr 8, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 607569c3-bea8-43dc-b3b2-6f218d3c2217

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4138/head:pr_4138 && git checkout pr_4138
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-72e63d4

@igooch igooch merged commit 12d17c2 into googleforgames:main Apr 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants