-
Notifications
You must be signed in to change notification settings - Fork 862
Promote FeatureDisableResyncOnSDKServer to Stable #4138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote FeatureDisableResyncOnSDKServer to Stable #4138
Conversation
Build Failed 😭 Build Id: ded58c8c-df23-4532-8d7d-5fcebe29dca9 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😭 Build Id: dc93314f-bd3d-4962-8b96-8085ac7a2b76 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
So |
Looks like it's tired of being ignored 😁 |
I've noticed it seems to be particularly that whole suite -- the Fleet just won't spin up. It also seems to only be on Autopilot. Not sure if the clusters have hit quota maybe? |
/gcbrun |
Build Succeeded 🥳 Build Id: a434857a-98fb-4d1a-8768-b63b7327758e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
2e29bff
to
7f2404f
Compare
7f2404f
to
910a458
Compare
Build Failed 😭 Build Id: 6c2c4863-4f2f-49d1-a5a1-1b48a9889db2 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: 607569c3-bea8-43dc-b3b2-6f218d3c2217 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
FeatureDisableResyncOnSDKServer has been in Beta, and on by default, for 11 months with no issues filed. This PR is to promote the feature to Stable, which means that the feature now cannot be turned off.
We maintain the feature flag name, so that on upgrade a new controller does not fail to parse the feature flag name.
Which issue(s) this PR fixes:
Closes # 4137
Special notes for your reviewer:
This PR does not warn that setting a stable feature flag to false is a no-op.
This PR does not include instructions for upgrading a SDK feature from Beta -> GA.
Those should be handled as separate issues / PRs.