Refactor image build and manifest push process #4118

0xaravindh · 2025-02-25T15:36:33Z

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Works on #3978

Special notes for your reviewer:

agones-bot · 2025-02-25T16:48:08Z

Build Succeeded 🥳

Build Id: 7b59a234-6ffc-438a-a057-e6980c1f88a1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-1ebe0d9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-1ebe0d9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-1ebe0d9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-1ebe0d9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-1ebe0d9
Linux C++ SDK (build): agonessdk-1.48.0-dev-1ebe0d9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-1ebe0d9.zip

A preview of the website (the last 30 builds are retained):

https://1ebe0d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4118/head:pr_4118 && git checkout pr_4118
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-1ebe0d9

igooch · 2025-03-10T05:38:02Z

@kangjk1017 do you have the ability pull, build & test the PR to see if it works on your windows nodes?

@0xaravindh and I do not have the ability to test on windows nodes. However, a fetch of this branch, local build, & push to a non-public artifact registry has a manifest with os.version for windows:

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3233,
         "digest": "sha256:df4fb05be305c3fa708e94ba52f87ad67c62d7f961af86c4dace4d69aa9c2ef0",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3039,
         "digest": "sha256:3290ff57551de10ed0171ad2b64e600a6034116c6cb9b53170f6230130c2ac62",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1101,
         "digest": "sha256:b3b687763426470a2fb2288c42784d1dc79a041b4934709574f2db6019c4524e",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.17763.6893"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1101,
         "digest": "sha256:b23a3a3aaac009f189a9c87ecd2bf314ec55da57caf35525602ef84ae3f567d7",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.20348.3207"
         }
      }
   ]
}

kangjk1017 · 2025-03-10T06:48:13Z

Thank you very much. It works perfectly.
I was able to run containers on both Linux and Windows nodes using the sidecar image us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-1ebe0d9.
Unfortunately, aside from using this built image, I’m in a difficult position to test anything else on my own.

Thank you again so much for all your work.

build/Makefile

gongmax · 2025-03-12T17:40:43Z

build/Makefile

@@ -528,7 +530,7 @@ build-controller-image-amd64: $(ensure-build-image) build-controller-binary buil
 	docker build $(agones_path)/cmd/controller/ --tag=$(controller_amd64_tag) $(DOCKER_BUILD_ARGS)
 # creating docker builder and then using that builder to build controller image in buildx command
 build-controller-image-arm64: $(ensure-build-image) build-controller-binary create-arm64-builder
-	docker buildx build --platform linux/arm64 --builder $(BUILDX_ARM64_BUILDER) --build-arg ARCH=arm64 $(agones_path)/cmd/controller/ --tag=$(controller_arm64_tag) $(DOCKER_BUILD_ARGS)
+	docker buildx build --provenance false --platform linux/arm64 --builder $(BUILDX_ARM64_BUILDER) --build-arg ARCH=arm64 $(agones_path)/cmd/controller/ --tag=$(controller_arm64_tag) $(DOCKER_BUILD_ARGS)


Is it needed to disable provenance for all the images? Can we limit it to only the windows sdk image?

provenance: false is needed to prevent unnecessary manifest files from cluttering up the artifact repository.

here is the old vs new manifest samples

agones-bot · 2025-03-18T04:45:19Z

Build Failed 😭

Build Id: dce486cf-a064-4bd8-a016-7f8299f1dd5a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-18T05:59:48Z

Build Failed 😭

Build Id: 19102980-19da-40ff-a974-9f02d1b87d4f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-18T06:00:55Z

Build Failed 😭

Build Id: 434f8313-81cf-4e7a-b827-94319db4edbd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-03-18T06:21:21Z

/gcbrun

agones-bot · 2025-03-18T07:13:43Z

Build Failed 😭

Build Id: e02dfb30-db03-4534-a7a5-2d12dfc1fdb8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-21T18:27:37Z

Build Failed 😭

Build Id: 0cf8c160-4425-44b0-af50-9fc841194266

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-03-21T18:42:24Z

/gcbrun

agones-bot · 2025-03-21T18:56:56Z

Build Failed 😭

Build Id: 5a6ee33a-9a97-46b3-bb45-620f542136dc

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-03-22T02:36:41Z

/gcbrun

agones-bot · 2025-03-22T02:50:42Z

Build Failed 😭

Build Id: 1c7b0406-51be-455a-941b-e36ae54c44c0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2025-03-24T17:07:37Z

/gcbrun

agones-bot · 2025-03-24T18:10:19Z

Build Succeeded 🥳

Build Id: 0ae67416-67ef-4627-9463-8c2fff8f920d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-527b8fa
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-527b8fa
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-527b8fa-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-527b8fa
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-527b8fa
Linux C++ SDK (build): agonessdk-1.48.0-dev-527b8fa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-527b8fa.zip

A preview of the website (the last 30 builds are retained):

https://527b8fa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4118/head:pr_4118 && git checkout pr_4118
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-527b8fa

agones-bot · 2025-03-25T15:50:55Z

Build Failed 😭

Build Id: c873ac21-a6f9-4fe7-acb0-39f4e8f20f96

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2025-03-25T16:06:28Z

/gcbrun

agones-bot · 2025-03-25T16:59:17Z

Build Succeeded 🥳

Build Id: fc466d5e-3da7-4772-841c-ac2c766a48d4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-5169bdc
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-5169bdc
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-5169bdc-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-5169bdc
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-5169bdc
Linux C++ SDK (build): agonessdk-1.48.0-dev-5169bdc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-5169bdc.zip

A preview of the website (the last 30 builds are retained):

https://5169bdc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4118/head:pr_4118 && git checkout pr_4118
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-5169bdc

github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Feb 25, 2025

0xaravindh self-assigned this Feb 25, 2025

0xaravindh marked this pull request as ready for review March 6, 2025 05:28

0xaravindh requested review from igooch, gongmax and markmandel March 10, 2025 02:46

gongmax reviewed Mar 12, 2025

View reviewed changes

gongmax approved these changes Mar 17, 2025

View reviewed changes

0xaravindh closed this Mar 18, 2025

0xaravindh force-pushed the buildx-manifest branch from c7ea1c0 to 3048c05 Compare March 18, 2025 04:59

fixes

4698ad8

0xaravindh reopened this Mar 18, 2025

Merge branch 'googleforgames:main' into buildx-manifest

527b8fa

Merge branch 'main' into buildx-manifest

5169bdc

igooch enabled auto-merge (squash) March 25, 2025 15:42

igooch disabled auto-merge March 25, 2025 15:59

gongmax merged commit ca09802 into googleforgames:main Mar 25, 2025
4 checks passed

0xaravindh mentioned this pull request Mar 25, 2025

Add Helm Chart Variable for Configuring SIDECAR_IMAGE Independently #3979

Closed

0xaravindh added the kind/bug These are bugs. label Mar 25, 2025

0xaravindh mentioned this pull request Apr 2, 2025

Cannot Use Agones SDK Image on Windows 2022 Node Due to Missing os.version in Docker Manifest #3978

Closed

Refactor image build and manifest push process #4118

Refactor image build and manifest push process #4118

Uh oh!

Conversation

0xaravindh commented Feb 25, 2025

Uh oh!

agones-bot commented Feb 25, 2025

Uh oh!

igooch commented Mar 10, 2025

Uh oh!

kangjk1017 commented Mar 10, 2025

Uh oh!

Uh oh!

gongmax Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

0xaravindh Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Mar 18, 2025

Uh oh!

agones-bot commented Mar 18, 2025

Uh oh!

agones-bot commented Mar 18, 2025

Uh oh!

0xaravindh commented Mar 18, 2025

Uh oh!

agones-bot commented Mar 18, 2025

Uh oh!

agones-bot commented Mar 21, 2025

Uh oh!

0xaravindh commented Mar 21, 2025

Uh oh!

agones-bot commented Mar 21, 2025

Uh oh!

0xaravindh commented Mar 22, 2025

Uh oh!

agones-bot commented Mar 22, 2025

Uh oh!

igooch commented Mar 24, 2025

Uh oh!

agones-bot commented Mar 24, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

gongmax commented Mar 25, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!