Skip to content

Fix: Ensure Buildx Builders Are Created or Used for ARM64 and Windows #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix: Ensure Buildx Builders Are Created or Used for ARM64 and Windows #4115

merged 2 commits into from
Feb 26, 2025

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

This PR ensures that Docker Buildx builders are either used if existing or created if missing for ARM64 and Windows platforms, preventing build failures.

ERROR: existing instance for "arm64-builder" but no append mode, specify the node name to make changes for existing instances

ERROR: existing instance for "windows-builder-ltsc2019" but no append mode, specify the node name to make changes for existing instances

Closes #

Special notes for your reviewer:

@0xaravindh 0xaravindh added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 19, 2025
@0xaravindh 0xaravindh self-assigned this Feb 19, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 67bd7391-b800-4add-a40b-b88b804522f6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh 0xaravindh requested review from igooch and gongmax February 19, 2025 15:03
@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: bdeed584-fc2f-4924-98ea-a9c1f68574cb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4115/head:pr_4115 && git checkout pr_4115
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-bb12810

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 30d36b10-947f-41e3-aabf-a7b1f42ab414

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4115/head:pr_4115 && git checkout pr_4115
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-23ecc7b

gongmax
gongmax reviewed Feb 25, 2025
View reviewed changes
@gongmax gongmax merged commit 78e1890 into googleforgames:main Feb 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@igooch igooch Awaiting requested review from igooch

Assignees

@0xaravindh 0xaravindh

Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xaravindh @agones-bot @gongmax