fix: bump version of jsonpatch for lossy max int64 #4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: e5880dfc-cb0f-4c28-bc09-117782483f3a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Did some manual, testing, it seems to be working well |
|
https://github.com/gomodules/jsonpatch/releases/tag/v2.5.0 contains this fix, so now we can update this PR to point to that release. |
c5fb555 to
91f7b74
Compare
1b66b83 to
91f7b74
Compare
|
Build Succeeded 🥳 Build Id: c3940116-8cea-4810-b3ab-f7ad33dc71c3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This PR bump the version of the jsonpath module, which includes a fix for the lossy int64 max values
Currently, the jsonpath transform the int64 (big values, max int64 for example) as a float64 with scientific notation, when cast back to a int64, it losses precision / the int64 is not the same.
Which issue(s) this PR fixes:
Closes #3636
Special notes for your reviewer:
A PR has been opened on the jsonpath repo: gomodules/jsonpatch#40
The repo doesn't seems to be maintained, I open this draft PR to do some test by using by fork