Initialise FCounterResponse members #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Build Failed 😭 Build Id: 88702def-c6c8-457a-9f04-84e669f88939 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
@GloryOfNight could you please do a quick review? |
Initialising members to their default values prevents compiler warnings: ``` Int64Property FCounterResponse::Count is not initialized properly even though its struct probably has a custom default constructor. Module:Agones File:Classes/Classes.h Int64Property FCounterResponse::Capacity is not initialized properly even though its struct probably has a custom default constructor. Module:Agones File:Classes/Classes.h ```
GloryOfNight
approved these changes
Jan 14, 2025
|
/gcbrun |
|
Build Failed 😭 Build Id: 8ce7c1a2-9158-4862-a1ee-8c42beb8afbc Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 4ee93cd6-b3c5-4b98-b8f9-396fc22fecd4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Initialising members to their default values prevents compiler warnings:
All other structs in this file do initialize their members, so this PR brings the FCounterResponse struct in-line with the others.
Which issue(s) this PR fixes:
Special notes for your reviewer:
I've successfully built this change in my work project. I can also build it in a new blank UE4 project if required.
I'm hoping this change is simple enough to not need that though 🙏