Skip to content

Add ability to change externalTrafficPolicy for agones-ping services (http&udp) #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2025
Merged

Add ability to change externalTrafficPolicy for agones-ping services (http&udp) #4083

merged 4 commits into from
Jan 13, 2025

Conversation

zifter
Copy link
Contributor

@zifter zifter commented Jan 6, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

We need the ability to set Local traffic policy for ping service.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
Pretty the same as #4022

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Jan 6, 2025
@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 87c259ae-5f17-490a-8d57-303a534e7332

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4083/head:pr_4083 && git checkout pr_4083
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-ad10a33

@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: d8d7a99e-5931-4941-9ca4-c397cfd8142b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4083/head:pr_4083 && git checkout pr_4083
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-8981ded

@igooch igooch enabled auto-merge (squash) January 13, 2025 22:30
igooch
igooch approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch
Copy link
Collaborator

igooch commented Jan 13, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 6d10de26-3c73-46c2-b1de-64100e2ea905

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4083/head:pr_4083 && git checkout pr_4083
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-ad3b385

@igooch igooch merged commit 00820f7 into googleforgames:main Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igooch igooch igooch approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zifter @0xaravindh @agones-bot @igooch