Add AFP features and update documentation #4061

0xaravindh · 2024-12-10T11:45:51Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Implement new AFP features, add AFP issue template, and enhance site documentation for AFP guidelines

Introduced a new GitHub issue template for feature proposals
Updated site documentation to include detailed instructions for the Agones Feature Proposal (AFP) process
Included metadata schema and workflow explanations in the documentation
Added references to the AFP template and review process

Which issue(s) this PR fixes:

Works on #3882

Special notes for your reviewer:

…documentation for AFP guidelines - Introduced a new GitHub issue template for feature proposals - Updated site documentation to include detailed instructions for the Agones Feature Proposal (AFP) process - Included metadata schema and workflow explanations in the documentation - Added references to the AFP template and review process

github-actions · 2024-12-10T11:46:09Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-12-11T07:22:23Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-12-11T08:26:44Z

Build Succeeded 🥳

Build Id: c581a967-0dc9-4082-96fa-7838dd79a85c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-cac907a
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-cac907a
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-cac907a-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-cac907a
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-cac907a
Linux C++ SDK (build): agonessdk-1.46.0-dev-cac907a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-cac907a.zip

A preview of the website (the last 30 builds are retained):

https://cac907a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-cac907a

github-actions · 2024-12-13T09:04:35Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-12-13T10:05:59Z

Build Succeeded 🥳

Build Id: 8d6f39d9-0a4f-4a38-9166-e9d3ebb348e7

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-450c8b5
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-450c8b5
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-450c8b5-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-450c8b5
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-450c8b5
Linux C++ SDK (build): agonessdk-1.46.0-dev-450c8b5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-450c8b5.zip

A preview of the website (the last 30 builds are retained):

https://450c8b5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-450c8b5

github-actions · 2024-12-16T05:19:21Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-12-16T06:53:30Z

Build Succeeded 🥳

Build Id: 96aa270d-e67e-4e91-9e18-5cfd3d2de7b4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-12c4385
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-12c4385
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-12c4385-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-12c4385
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-12c4385
Linux C++ SDK (build): agonessdk-1.46.0-dev-12c4385-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-12c4385.zip

A preview of the website (the last 30 builds are retained):

https://12c4385-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-12c4385

github-actions · 2024-12-17T04:28:15Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-12-17T04:29:07Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-12-17T05:36:49Z

Build Succeeded 🥳

Build Id: 61d23164-db1d-4163-b70e-9122ea736451

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-92baa26
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-92baa26
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-92baa26-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-92baa26
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-92baa26
Linux C++ SDK (build): agonessdk-1.46.0-dev-92baa26-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-92baa26.zip

A preview of the website (the last 30 builds are retained):

https://92baa26-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-92baa26

gongmax

Looks like you were following exactly how KEP is setup, which I don't think is necessary since it's too comprehensive for us. For our case, we just need to document the process of AFP, which is majorly the below part in the description of #3882 (which majorly including creates a PR and an issue), document the structure of the AFP PR, and probably also provide an example AFP PR template in the agones/docs/proposal folder. The structure of the AFP PR can be similar as the top level structure of this design doc: #2716

The process of AFP, quote from #3882 :
"When someone wants to write a design, start with an issue outlining the problem. After that, they have two options:
For smaller changes, writing it in the issue is still fine.
For larger changes, or when asked by a maintainer because the conversation is getting unwieldy, they submit an AFP PR
An AFP PR is as simple as a PR that adds a file in agones/docs/features. The PR should be titled AFP-00x and the file named 00x-feature-name.md.
Everyone can then participate on the PR, selecting text they want to comment on and having conversations there.
When we reach lazy consensus, a maintainer can approve and submit.
Every AFP OR should be tied back to an issue"

github-actions · 2025-02-03T05:24:24Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2025-02-03T06:31:17Z

Build Succeeded 🥳

Build Id: f8bd7609-9636-4d99-84c7-9186fbba2821

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.47.0-dev-567d498
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.47.0-dev-567d498
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.47.0-dev-567d498-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.47.0-dev-567d498
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.47.0-dev-567d498
Linux C++ SDK (build): agonessdk-1.47.0-dev-567d498-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.47.0-dev-567d498.zip

A preview of the website (the last 30 builds are retained):

https://567d498-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-567d498

agones-bot · 2025-03-11T19:42:24Z

Build Failed 😭

Build Id: 11bc9dee-8b38-4358-8722-a789050d6e56

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2025-03-13T23:22:23Z

.github/ISSUE_TEMPLATE/agones_feature_proposal.md

@@ -0,0 +1,34 @@
+---


I think my above comments still makes sense. The idea is for smaller changes we still want to give contributer a way to just state their design in the feature request issue. For large larger changes, they can submit an AFP PR and link to the feature request issue.

site/content/en/docs/Contribute/agones-feature-proposal.md

docs/proposals/0000-afp-process/README.md

agones-bot · 2025-03-24T07:41:01Z

Build Failed 😭

Build Id: f1bab576-57bb-4a38-b19b-ff9982897d42

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-03-25T02:38:31Z

/gcbrun

agones-bot · 2025-03-25T03:08:20Z

Build Failed 😭

Build Id: 56186259-5f8a-40e9-b592-52b927496495

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-25T07:38:32Z

Build Failed 😭

Build Id: 485104be-bba2-4846-b2e1-cdd585eb7309

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-03-25T08:21:02Z

/gcbrun

agones-bot · 2025-03-25T09:20:55Z

Build Succeeded 🥳

Build Id: b140e069-696a-48b9-bca0-081a363aace8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-ebda49d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-ebda49d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-ebda49d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-ebda49d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-ebda49d
Linux C++ SDK (build): agonessdk-1.48.0-dev-ebda49d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-ebda49d.zip

A preview of the website (the last 30 builds are retained):

https://ebda49d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-ebda49d

docs/proposals/README.md

site/content/en/docs/Contribute/agones-feature-proposal.md

agones-bot · 2025-04-01T06:20:21Z

Build Failed 😭

Build Id: 56fd7f9b-c847-4181-af1e-93af016527f6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-04-01T09:21:43Z

/gcbrun

agones-bot · 2025-04-01T10:07:54Z

Build Failed 😭

Build Id: de66ce1b-57f5-47d1-bfe5-0f17defdefac

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2025-04-01T16:26:21Z

/gcbrun

agones-bot · 2025-04-01T16:36:08Z

Build Failed 😭

Build Id: 8048923b-9193-46dd-b79d-7d8ec1ed3e77

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2025-04-01T16:41:48Z

/gcbrun

agones-bot · 2025-04-01T16:52:38Z

Build Failed 😭

Build Id: f8676945-bcb0-4a42-af44-de2c893e1a2b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2025-04-01T16:57:41Z

CI failed on error https://pantheon.corp.google.com/cloud-build/builds/f8676945-bcb0-4a42-af44-de2c893e1a2b;step=20?e=HybridGceDiskLaunch::HybridGceDiskDisabled,HybridGceSnapshotLaunch::HybridGceSnapshotDisabled&invt=Abtm2Q&mods=monitoring_api_staging&project=agones-images. Please take a look @0xaravindh

0xaravindh · 2025-04-02T04:31:31Z

/gcbrun

agones-bot · 2025-04-02T05:47:10Z

Build Succeeded 🥳

Build Id: 0fb01f4e-6a54-4686-a401-88e21daa088d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.49.0-dev-9ab4469
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.49.0-dev-9ab4469
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.49.0-dev-9ab4469-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.49.0-dev-9ab4469
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.49.0-dev-9ab4469
Linux C++ SDK (build): agonessdk-1.49.0-dev-9ab4469-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.49.0-dev-9ab4469.zip

A preview of the website (the last 30 builds are retained):

https://9ab4469-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4061/head:pr_4061 && git checkout pr_4061
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-9ab4469

github-actions bot added the kind/breaking Breaking change label Dec 10, 2024

github-actions bot added the size/XL label Dec 10, 2024

0xaravindh added kind/feature New features for Agones kind/documentation Documentation for Agones labels Dec 10, 2024

0xaravindh requested a review from markmandel December 10, 2024 11:46

0xaravindh self-assigned this Dec 10, 2024

0xaravindh requested review from gongmax and igooch December 10, 2024 11:47

0xaravindh added 2 commits December 11, 2024 04:10

Merge branch 'main' of https://github.com/0xaravindh/agones into afp

9afb297

Fix broken links

cac907a

Merge branch 'googleforgames:main' into afp

450c8b5

0xaravindh marked this pull request as ready for review December 14, 2024 02:41

Merge branch 'googleforgames:main' into afp

12c4385

fix broken link

d8f93b9

update_site_changes

92baa26

gongmax reviewed Dec 17, 2024

View reviewed changes

Merge branch 'googleforgames:main' into afp

567d498

Update AFP process

f3328bf

googleforgames deleted a comment from agones-bot Mar 12, 2025

gongmax reviewed Mar 13, 2025

View reviewed changes

0xaravindh added 2 commits March 24, 2025 07:23

Merge branch 'googleforgames:main' into afp

1b1c784

fixes

e7f6a7d

Add GitHub proposals URL to IgnoreURLs list

ebda49d

gongmax reviewed Mar 27, 2025

View reviewed changes

docs/proposals/README.md Outdated Show resolved Hide resolved

site/content/en/docs/Contribute/agones-feature-proposal.md Outdated Show resolved Hide resolved

0xaravindh added 2 commits April 1, 2025 05:26

Merge branch 'googleforgames:main' into afp

08094d8

issue-template-update

9ab4469

gongmax approved these changes Apr 1, 2025

View reviewed changes

gongmax enabled auto-merge (squash) April 1, 2025 16:26

gongmax merged commit 83c2afe into googleforgames:main Apr 2, 2025
4 checks passed

0xaravindh mentioned this pull request Apr 2, 2025

Meta proposal: AFP: Agones Feature Process #3882

Closed

Add AFP features and update documentation #4061

Add AFP features and update documentation #4061

Uh oh!

Conversation

0xaravindh commented Dec 10, 2024

Uh oh!

github-actions bot commented Dec 10, 2024

Uh oh!

github-actions bot commented Dec 11, 2024

Uh oh!

agones-bot commented Dec 11, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

agones-bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 16, 2024

Uh oh!

agones-bot commented Dec 16, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

agones-bot commented Dec 17, 2024

Uh oh!

gongmax left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

agones-bot commented Feb 3, 2025

Uh oh!

agones-bot commented Mar 11, 2025

Uh oh!

gongmax Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Mar 24, 2025

Uh oh!

0xaravindh commented Mar 25, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

0xaravindh commented Mar 25, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Apr 1, 2025

Uh oh!

0xaravindh commented Apr 1, 2025

Uh oh!

agones-bot commented Apr 1, 2025

Uh oh!

gongmax commented Apr 1, 2025

Uh oh!

agones-bot commented Apr 1, 2025

Uh oh!

gongmax commented Apr 1, 2025

Uh oh!

agones-bot commented Apr 1, 2025

Uh oh!

gongmax commented Apr 1, 2025

Uh oh!

0xaravindh commented Apr 2, 2025

Uh oh!

agones-bot commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!