Delete List Value(s) on Game Server Allocation #4054

igooch · 2024-12-02T22:57:08Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds the ability to delete value(s) from a List during game server allocation.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Commits have been broken out into the different parts of this PR. Follows the existing code for AddValues during game server allocation.

agones-bot · 2024-12-02T23:03:25Z

Build Failed 😭

Build Id: 47d4b269-fe90-4424-9b8f-6ba839d0acac

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-02T23:16:41Z

Build Failed 😭

Build Id: f2a8871d-a4e1-4bef-8389-61062455862c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-02T23:38:00Z

Build Failed 😭

Build Id: 17830196-457e-46df-879e-edf90781c394

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-03T01:39:17Z

Build Succeeded 🥳

Build Id: f5386a51-2f6c-47e1-a361-6c23e4d77a5b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-9786b90
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-9786b90
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-9786b90-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-9786b90
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-9786b90
Linux C++ SDK (build): agonessdk-1.46.0-dev-9786b90-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-9786b90.zip

A preview of the website (the last 30 builds are retained):

https://9786b90-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-9786b90

agones-bot · 2024-12-09T19:21:52Z

Build Succeeded 🥳

Build Id: 92ea4d8f-27a0-4c0c-830b-88af543ded89

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-730ac2c
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-730ac2c
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-730ac2c-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-730ac2c
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-730ac2c
Linux C++ SDK (build): agonessdk-1.46.0-dev-730ac2c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-730ac2c.zip

A preview of the website (the last 30 builds are retained):

https://730ac2c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-730ac2c

gongmax

LGTM, some minor comments

pkg/apis/agones/v1/gameserver.go

proto/allocation/allocation.proto

agones-bot · 2024-12-12T18:58:52Z

Build Failed 😭

Build Id: 83966ad6-da24-4865-a393-14f622fe8d69

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-12T19:14:08Z

Build Failed 😭

Build Id: 1dccaa11-64ab-4970-8e74-61d1a96c009f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-12T23:37:28Z

Build Failed 😭

Build Id: ab299876-0f03-4d59-833c-a8a69dbdf787

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-12-13T01:08:01Z

Build Succeeded 🥳

Build Id: 180054e6-2378-4201-b5fa-5934a1d99178

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-d9186e0
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-d9186e0
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-d9186e0-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-d9186e0
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-d9186e0
Linux C++ SDK (build): agonessdk-1.46.0-dev-d9186e0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-d9186e0.zip

A preview of the website (the last 30 builds are retained):

https://d9186e0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-d9186e0

igooch added 3 commits December 2, 2024 13:35

Adds DeleteValues as a ListAction during allocation

15c0dbf

Generated Files

c531b5d

Adds tests

71e382c

igooch requested review from gongmax and peterzhongyi December 2, 2024 22:57

github-actions bot added kind/feature New features for Agones size/M labels Dec 2, 2024

igooch force-pushed the delete-on-allocate branch from 776e19c to a24c85a Compare December 2, 2024 23:09

Adds DeleteValues documentation

9786b90

igooch force-pushed the delete-on-allocate branch from a24c85a to 9786b90 Compare December 2, 2024 23:23

Merge branch 'main' into delete-on-allocate

730ac2c

gongmax reviewed Dec 11, 2024

View reviewed changes

pkg/apis/agones/v1/gameserver.go Show resolved Hide resolved

proto/allocation/allocation.proto Show resolved Hide resolved

Updates tabs to spaces per protobuf style guide

916ef02

Generate Rust file

e564257

Adds unit test for DeleteListValues

87ec578

gongmax approved these changes Dec 12, 2024

View reviewed changes

Merge branch 'main' into delete-on-allocate

f4aabcb

gongmax enabled auto-merge (squash) December 12, 2024 23:27

Merge branch 'main' into delete-on-allocate

d9186e0

gongmax merged commit 3c5b7df into googleforgames:main Dec 13, 2024
4 checks passed

igooch deleted the delete-on-allocate branch December 20, 2024 01:18

markmandel mentioned this pull request Apr 13, 2025

ListAction DeleteValues doesn't show up on the generated API reference #4150

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Delete List Value(s) on Game Server Allocation #4054

Delete List Value(s) on Game Server Allocation #4054

Uh oh!

igooch commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 3, 2024

Uh oh!

agones-bot commented Dec 9, 2024

Uh oh!

gongmax left a comment

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 13, 2024

Uh oh!

Uh oh!

Uh oh!

Delete List Value(s) on Game Server Allocation #4054

Delete List Value(s) on Game Server Allocation #4054

Uh oh!

Conversation

igooch commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 2, 2024

Uh oh!

agones-bot commented Dec 3, 2024

Uh oh!

agones-bot commented Dec 9, 2024

Uh oh!

gongmax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 12, 2024

Uh oh!

agones-bot commented Dec 13, 2024

Uh oh!

Uh oh!

Uh oh!